Changeset 263619 in webkit

Timestamp:

Jun 27, 2020 8:53:41 AM (4 years ago)

Author:

sbarati@apple.com

Message:

BytecodeBasicBlock::addSuccessor should check if the successor already exists
​https://bugs.webkit.org/show_bug.cgi?id=213670

Reviewed by Yusuke Suzuki.

It makes it nicer for algorithms using BytecodeGraph to not have to consider
whether or not there are duplicates in the successor list. Also, because of
this, bytecode liveness was doing extra work since it walked the successor list,
including any duplicates in it.

• bytecode/BytecodeBasicBlock.h:

(JSC::BytecodeBasicBlock::addSuccessor):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecode/BytecodeBasicBlock.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-06-27  Saam Barati  <sbarati@apple.com>
+
+        BytecodeBasicBlock::addSuccessor should check if the  successor already exists
+        https://bugs.webkit.org/show_bug.cgi?id=213670
+
+        Reviewed by Yusuke Suzuki.
+
+        It makes it nicer for algorithms using BytecodeGraph to not have to consider
+        whether or not there are duplicates in the successor list. Also, because of
+        this, bytecode liveness was doing extra work since it walked the successor list,
+        including any duplicates in it.
+
+        * bytecode/BytecodeBasicBlock.h:
+        (JSC::BytecodeBasicBlock::addSuccessor):
+
 2020-06-27  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/bytecode/BytecodeBasicBlock.h

@@ -78 +78 @@
     void shrinkToFit();
 
-    void addSuccessor(BytecodeBasicBlock& block) { m_successors.append(block.index()); }
+    void addSuccessor(BytecodeBasicBlock& block)
+    {
+        if (!m_successors.contains(block.index()))
+            m_successors.append(block.index());
+    }
 
     inline void addLength(unsigned);