Changeset 263624 in webkit

Timestamp:

Jun 27, 2020 9:44:03 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Require <form> to be connected
​https://bugs.webkit.org/show_bug.cgi?id=177356

Patch by Rob Buis <​rbuis@igalia.com> on 2020-06-27
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Update improved test result.

• web-platform-tests/html/semantics/forms/form-submission-0/submission-checks.window-expected.txt:

Source/WebCore:

Implement step 1 of [1], i.e. do not submit form if it
is not connected.

Test: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/submission-checks.html

[1] ​https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-form-submit

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::submit):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/submission-checks.window-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLFormElement.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2020-06-27  Rob Buis  <rbuis@igalia.com>
+
+        Require <form> to be connected
+        https://bugs.webkit.org/show_bug.cgi?id=177356
+
+        Reviewed by Sam Weinig.
+
+        Update improved test result.
+
+        * web-platform-tests/html/semantics/forms/form-submission-0/submission-checks.window-expected.txt:
+
 2020-06-27  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/submission-checks.window-expected.txt

@@ -1 +1 @@
 
-FAIL <form> not connected to a document cannot navigate assert_unreached: Reached unreachable code
-FAIL <form> not connected to a document after submit event cannot navigate assert_unreached: Reached unreachable code
+PASS <form> not connected to a document cannot navigate 
+PASS <form> not connected to a document after submit event cannot navigate 
 PASS <form> in a navigated document cannot navigate 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-06-27  Rob Buis  <rbuis@igalia.com>
+
+        Require <form> to be connected
+        https://bugs.webkit.org/show_bug.cgi?id=177356
+
+        Reviewed by Sam Weinig.
+
+        Implement step 1 of [1], i.e. do not submit form if it
+        is not connected.
+
+        Test: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/submission-checks.html
+
+        [1] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#concept-form-submit
+
+        * html/HTMLFormElement.cpp:
+        (WebCore::HTMLFormElement::submit):
+
 2020-06-27  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/html/HTMLFormElement.cpp

@@ -335 +335 @@
 void HTMLFormElement::submit(Event* event, bool activateSubmitButton, bool processingUserGesture, FormSubmissionTrigger formSubmissionTrigger)
 {
+    // The prepareForSubmission function also does this check, but we need to do it here
+    // too, since there are some code paths that bypass that function.
+    if (!isConnected())
+        return;
+
     RefPtr<FrameView> view = document().view();
     RefPtr<Frame> frame = document().frame();