Changeset 263648 in webkit

Timestamp:

Jun 29, 2020 2:32:52 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r263625): run-minibrowser --debug/--release options gone
​https://bugs.webkit.org/show_bug.cgi?id=213697

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-06-29
Reviewed by Žan Doberšek.

• Scripts/webkitpy/minibrowser/run_webkit_app.py:

(main): Explicitely skip the --target option. Previous code was also skipping --release and
--debug options because their dest is the same as with the --target option.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/minibrowser/run_webkit_app.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-06-29  Philippe Normand  <pnormand@igalia.com>
+
+        REGRESSION(r263625): run-minibrowser --debug/--release options gone
+        https://bugs.webkit.org/show_bug.cgi?id=213697
+
+        Reviewed by Žan Doberšek.
+
+        * Scripts/webkitpy/minibrowser/run_webkit_app.py:
+        (main): Explicitely skip the --target option. Previous code was also skipping --release and
+        --debug options because their `dest` is the same as with the --target option.
+
 2020-06-29  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/Scripts/webkitpy/minibrowser/run_webkit_app.py

@@ -38 +38 @@
         for option in group_options:
             # Skip deprecated option
-            if option.dest == "configuration":
-                continue
-            default = None
-            if option.default != ("NO", "DEFAULT"):
-                default = option.default
-            option_group.add_argument(option.get_opt_string(), action=option.action, dest=option.dest,
-                                      help=option.help, const=option.const, default=default)
+            if option.get_opt_string() != "--target":
+                default = None
+                if option.default != ("NO", "DEFAULT"):
+                    default = option.default
+                option_group.add_argument(option.get_opt_string(), action=option.action, dest=option.dest,
+                                          help=option.help, const=option.const, default=default)
 
     options, args = option_parser.parse_known_args(argv)
+
+    if not options.configuration:
+        options.configuration = "Release"
 
     if set(args).issubset(["-h", "--help"]) and not options.platform: