Changeset 263653 in webkit

Timestamp:

Jun 29, 2020 3:54:34 AM (4 years ago)

Author:

ddkilzer@apple.com

Message:

REGRESSION (r262776): Leak of NSMutableURLRequest in -[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]
<​https://webkit.org/b/213690>
<rdar://problem/64853619>

Reviewed by Anders Carlsson.

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):

• Use RetainPtr<> for the mutable copy and autorelease the return value.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-06-29  David Kilzer  <ddkilzer@apple.com>
+
+        REGRESSION (r262776): Leak of NSMutableURLRequest in -[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]
+        <https://webkit.org/b/213690>
+        <rdar://problem/64853619>
+
+        Reviewed by Anders Carlsson.
+
+        * platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
+        (-[WebCoreResourceHandleAsOperationQueueDelegate connection:willSendRequest:redirectResponse:]):
+        - Use RetainPtr<> for the mutable copy and autorelease the
+          return value.
+
 2020-06-29  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm

@@ -125 +125 @@
         // CFNetwork will add "application/x-www-form-urlencoded" content-type for POST, even if no Content-Type was specified, remove it in that case.
         if (m_handle && equalLettersIgnoringASCIICase(m_handle->firstRequest().httpMethod(), "post") && !m_handle->firstRequest().hasHTTPHeaderField(HTTPHeaderName::ContentType)) {
-            NSMutableURLRequest *modifiedRequest = [newRequest mutableCopy];
-            [modifiedRequest setValue:nil forHTTPHeaderField:@"Content-Type"];
-            return modifiedRequest;
+            auto mutableModifiedRequest = adoptNS([newRequest mutableCopy]);
+            [mutableModifiedRequest setValue:nil forHTTPHeaderField:@"Content-Type"];
+            return mutableModifiedRequest.autorelease();
         }
         return newRequest;