Changeset 263718 in webkit


Ignore:
Timestamp:
Jun 29, 2020 6:59:29 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
​https://bugs.webkit.org/show_bug.cgi?id=213578

Patch by Guowei Yang <​guowei_yang@apple.com> on 2020-06-29
.:

Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.

Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.

  • Source/cmake/WebKitFeatures.cmake: added definition of CoreImage-accelerated filter rendering feature flag, ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER

Source/WebCore:

Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.

Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.

No tests are required because this is just a feature flag set up

  • page/Settings.yaml: added default settings for the feature flag. Default value of the feature switch is off

Source/WebKit:

Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.

Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.

  • Shared/WebPreferences.yaml: added feature flag definition

Source/WTF:

Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.

Preparing to implement CoreImage backed filter rendering
Needs Compiler guards and experimental feature guard.

  • wtf/PlatformEnableCocoa.h: Added definition of a feature flag, ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
  • wtf/PlatformUse.h: Added compiler guard #define USE_CORE_IMAGE 1 to indicate whether CoreImage code is visible to the compiler
Location:
trunk
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/ChangeLog

    r263700 r263718  
     12020-06-29  Guowei Yang  <guowei_yang@apple.com>
     2
     3        Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
     4        https://bugs.webkit.org/show_bug.cgi?id=213578
     5
     6        Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
     7
     8        Preparing to implement CoreImage backed filter rendering
     9        Needs Compiler guards and experimental feature guard.
     10
     11        * Source/cmake/WebKitFeatures.cmake: added definition of
     12          CoreImage-accelerated filter rendering feature flag,
     13          ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
     14
    1152020-06-29  Tetsuharu Ohzeki  <tetsuharu.ohzeki@gmail.com>
    216

  • trunk/Source/WTF/ChangeLog

    r263700 r263718  
     12020-06-29  Guowei Yang  <guowei_yang@apple.com>
     2
     3        Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
     4        https://bugs.webkit.org/show_bug.cgi?id=213578
     5
     6        Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
     7
     8        Preparing to implement CoreImage backed filter rendering
     9        Needs Compiler guards and experimental feature guard.
     10
     11        * wtf/PlatformEnableCocoa.h: Added definition of a feature flag,
     12          ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER
     13        * wtf/PlatformUse.h:  Added compiler guard #define USE_CORE_IMAGE 1
     14          to indicate whether CoreImage code is visible to the compiler
     15
    1162020-06-29  Tetsuharu Ohzeki  <tetsuharu.ohzeki@gmail.com>
    217

  • trunk/Source/WTF/wtf/PlatformEnableCocoa.h

    r263474 r263718  
    4848#endif
    4949
     50#if !defined(ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER)
     51#define ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER 1
     52#endif
     53
    5054#if !defined(ENABLE_AIRPLAY_PICKER) && (PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST))
    5155#define ENABLE_AIRPLAY_PICKER 1

  • trunk/Source/WTF/wtf/PlatformUse.h

    r261333 r263718  
    5959#endif
    6060
     61#if PLATFORM(COCOA)
     62#define USE_CORE_IMAGE 1
     63#endif
     64
    6165#if PLATFORM(GTK) || PLATFORM(WPE)
    6266#define USE_GLIB 1

  • trunk/Source/WebCore/ChangeLog

    r263717 r263718  
     12020-06-29  Guowei Yang  <guowei_yang@apple.com>
     2
     3        Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
     4        https://bugs.webkit.org/show_bug.cgi?id=213578
     5
     6        Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
     7
     8        Preparing to implement CoreImage backed filter rendering
     9        Needs Compiler guards and experimental feature guard.
     10
     11        No tests are required because this is just a feature flag set up
     12
     13        * page/Settings.yaml: added default settings for the feature flag.
     14          Default value of the feature switch is off
     15
    1162020-06-29  Stephan Szabo  <stephan.szabo@sony.com>
    217

  • trunk/Source/WebCore/page/Settings.yaml

    r263270 r263718  
    420420  onChange: setNeedsRelayoutAllFrames
    421421
     422coreImageAcceleratedFilterRenderEnabled:
     423  initial: false
     424  onChange: setNeedsRelayoutAllFrames
     425
    422426legacyOverflowScrollingTouchEnabled:
    423427  initial: true

  • trunk/Source/WebKit/ChangeLog

    r263707 r263718  
     12020-06-29  Guowei Yang  <guowei_yang@apple.com>
     2
     3        Adding Experimental Feature Flags for CoreImage backed SVG/CSS Filters
     4        https://bugs.webkit.org/show_bug.cgi?id=213578
     5
     6        Reviewed by Darin Adler, Simon Fraser, Myles C. Maxfield.
     7
     8        Preparing to implement CoreImage backed filter rendering
     9        Needs Compiler guards and experimental feature guard.
     10
     11        * Shared/WebPreferences.yaml: added feature flag definition
     12
    1132020-06-29  Peng Liu  <peng.liu6@apple.com>
    214

  • trunk/Source/WebKit/Shared/WebPreferences.yaml

    r263700 r263718  
    20612061  defaultValue: true
    20622062  condition: ENABLE(MEDIA_STREAM)
     2063
     2064CoreImageAcceleratedFilterRenderEnabled:
     2065  type: bool
     2066  defaultValue: false
     2067  humanReadableName: "CoreImage-Accelerated Filter Rendering"
     2068  humanReadableDescription: "Accelerated CSS and SVG filter rendering using CoreImage"
     2069  category: experimental
     2070  condition: ENABLE(CORE_IMAGE_ACCELERATED_FILTER_RENDER)

  • trunk/Source/cmake/WebKitFeatures.cmake

    r263700 r263718  
    9898    WEBKIT_OPTION_DEFINE(ENABLE_3D_TRANSFORMS "Toggle 3D transforms support" PRIVATE ON)
    9999    WEBKIT_OPTION_DEFINE(ENABLE_ACCELERATED_2D_CANVAS "Toggle Accelerated 2D Canvas support" PRIVATE OFF)
     100    WEBKIT_OPTION_DEFINE(ENABLE_CORE_IMAGE_ACCELERATED_FILTER_RENDER "Toggle Accelerated CSS/SVG Filter Rendering using CoreImage" PRIVATE OFF)
    100101    WEBKIT_OPTION_DEFINE(ENABLE_ACCESSIBILITY "Whether to enable support for accessibility" PRIVATE ON)
    101102    WEBKIT_OPTION_DEFINE(ENABLE_ACCESSIBILITY_ISOLATED_TREE "Toggle accessibility isolated tree support" PRIVATE OFF)
Note: See TracChangeset for help on using the changeset viewer.