Changeset 263966 in webkit

Timestamp:

Jul 6, 2020 5:13:08 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

BubblewrapLauncher.cpp: Add paths required for sndio
​https://bugs.webkit.org/show_bug.cgi?id=212524

Information about the paths currently ins't into the sndio
documentation but it can be found in this email:
​http://www.sndio.org/arch/0077.html

Patch by Haelwenn (lanodan) Monnier <​contact@hacktivis.me> on 2020-07-06
Reviewed by Adrian Perez de Castro.

Manually tested, there is currently no automatic tests for it

• UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bindSndio):
(WebKit::bubblewrapSpawn):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Launcher/glib/BubblewrapLauncher.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-07-06  Haelwenn (lanodan) Monnier  <contact@hacktivis.me>
+
+        BubblewrapLauncher.cpp: Add paths required for sndio
+        https://bugs.webkit.org/show_bug.cgi?id=212524
+
+        Information about the paths currently ins't into the sndio
+        documentation but it can be found in this email:
+        http://www.sndio.org/arch/0077.html
+
+        Reviewed by Adrian Perez de Castro.
+
+        Manually tested, there is currently no automatic tests for it
+
+        * UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+        (WebKit::bindSndio):
+        (WebKit::bubblewrapSpawn):
+
 2020-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp

@@ -380 +380 @@
     // This is the ultimate fallback to raw ALSA
     bindIfExists(args, "/dev/snd", BindFlags::Device);
+}
+
+static void bindSndio(Vector<CString>& args)
+{
+    bindIfExists(args, "/tmp/sndio", BindFlags::ReadWrite);
+
+    GUniquePtr<char> sndioUidDir(g_strdup_printf("/tmp/sndio-%d", getuid()));
+    bindIfExists(args, sndioUidDir.get(), BindFlags::ReadWrite);
+
+    const char* homeDir = g_get_home_dir();
+    GUniquePtr<char> sndioHomeDir(g_build_filename(homeDir, ".sndio", nullptr));
+    bindIfExists(args, sndioHomeDir.get(), BindFlags::ReadWrite);
 }
 
@@ -807 +819 @@
         // FIXME: We should move to Pipewire as soon as viable, Pulse doesn't restrict clients atm.
         bindPulse(sandboxArgs);
+        bindSndio(sandboxArgs);
         bindFonts(sandboxArgs);
         bindGStreamerData(sandboxArgs);