Changeset 264975 in webkit

Timestamp:

Jul 28, 2020 5:18:06 AM (4 years ago)

Author:

calvaris@igalia.com

Message:

[GStreamer] media/vp9.html failing since check-in in r263894
​https://bugs.webkit.org/show_bug.cgi?id=213947

Reviewed by Philippe Normand.

Source/WebCore:

Test: media/vp9.html.

• testing/Internals.cpp:

(WebCore::Internals::usingGStreamer const): Added.

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• media/vp9.html: Used usingGStreamer() to adjust expectation of

the first test and to enable the second. Both are passing now for
GStreamer ports.

• platform/glib/TestExpectations: Removed media/vp9.html failure

from expectations.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/vp9.html (modified) (1 diff)
• LayoutTests/platform/glib/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/testing/Internals.cpp (modified) (1 diff)
• Source/WebCore/testing/Internals.h (modified) (1 diff)
• Source/WebCore/testing/Internals.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-07-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GStreamer] media/vp9.html failing since check-in in r263894
+        https://bugs.webkit.org/show_bug.cgi?id=213947
+
+        Reviewed by Philippe Normand.
+
+        * media/vp9.html: Used usingGStreamer() to adjust expectation of
+        the first test and to enable the second. Both are passing now for
+        GStreamer ports.
+        * platform/glib/TestExpectations: Removed media/vp9.html failure
+        from expectations.
+
 2020-07-28  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/LayoutTests/media/vp9.html

@@ -8 +8 @@
 
 test(() => {
-    assert_equals(video.canPlayType("video/mp4; codecs=vp9"), "", "canPlayType");
+    let expectedVP9Support = ""
+    if (window.internals && window.internals.usingGStreamer())
+        expectedVP9Support = "probably"
+    assert_equals(video.canPlayType("video/mp4; codecs=vp9"), expectedVP9Support, "canPlayType");
 }, "HTMLMediaElement.canPlay VP9");
 
 promise_test(async() => {
-    if (window.internals && !window.internals.usingAppleInternalSDK())
+    if (window.internals && !window.internals.usingGStreamer() && !window.internals.usingAppleInternalSDK())
         return;
     await video.play();

trunk/LayoutTests/platform/glib/TestExpectations

@@ -223 +223 @@
 
 webkit.org/b/211995 fast/images/animated-image-mp4.html [ Failure ]
-webkit.org/b/213947 media/vp9.html [ Failure ]
 
 webkit.org/b/214038 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-cues-cuechange.html [ Missing Failure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-07-28  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GStreamer] media/vp9.html failing since check-in in r263894
+        https://bugs.webkit.org/show_bug.cgi?id=213947
+
+        Reviewed by Philippe Normand.
+
+        Test: media/vp9.html.
+
+        * testing/Internals.cpp:
+        (WebCore::Internals::usingGStreamer const): Added.
+        * testing/Internals.h:
+        * testing/Internals.idl:
+
 2020-07-27  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/testing/Internals.cpp

@@ -5542 +5542 @@
 }
 
+bool Internals::usingGStreamer() const
+{
+#if USE(GSTREAMER)
+    return true;
+#else
+    return false;
+#endif
+}
+
 void Internals::setCaptureExtraNetworkLoadMetricsEnabled(bool value)
 {

trunk/Source/WebCore/testing/Internals.h

@@ -840 +840 @@
 
     bool usingAppleInternalSDK() const;
+    bool usingGStreamer() const;
 
     struct NowPlayingState {

trunk/Source/WebCore/testing/Internals.idl

@@ -861 +861 @@
 
     boolean usingAppleInternalSDK();
+    boolean usingGStreamer();
 
     void postTask(VoidCallback callback);