Changeset 265027 in webkit
- Timestamp:
- Jul 28, 2020 9:31:28 PM (4 years ago)
- Location:
- trunk/Source/WebInspectorUI
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebInspectorUI/ChangeLog
r265008 r265027 1 2020-07-28 Brian Burg <bburg@apple.com> 2 3 Web Inspector: REGRESSION(r255396): Audit: button to exit edit mode in main content area is missing border 4 https://bugs.webkit.org/show_bug.cgi?id=214898 5 <rdar://problem/66238391> 6 7 Reviewed by Devin Rousso. 8 9 * UserInterface/Base/Main.js: codify that this function only accepts ButtonNavigationItems. 10 Future developers, you'll need to adjust the CSS for non-button navigation items to work out. 11 12 * UserInterface/Views/Main.css: 13 (.navigation-item-help > .navigation-bar > .item.button): 14 (.navigation-item-help > .navigation-bar > .item.button:not(.text-only)): 15 (.navigation-item-help > .navigation-bar > .item.button.text-only): 16 (.navigation-item-help > .navigation-bar > .item): Deleted. 17 (.navigation-item-help > .navigation-bar > .item:not(.text-only)): Deleted. 18 (.navigation-item-help > .navigation-bar > .item.text-only): Deleted. 19 Split out the rules for text-only buttons. The regressing change added more specificity 20 for the text + image case which made the border transparent and removed extra padding. 21 Also add .button since we only expect buttons to be used in this context. 22 1 23 2020-07-28 Brian Burg <bburg@apple.com> 2 24 -
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
r264959 r265027 2940 2940 { 2941 2941 console.assert(typeof formatString === "string"); 2942 console.assert(navigationItem instanceof WI. NavigationItem);2942 console.assert(navigationItem instanceof WI.ButtonNavigationItem); 2943 2943 2944 2944 function append(a, b) { -
trunk/Source/WebInspectorUI/UserInterface/Views/Main.css
r265008 r265027 236 236 } 237 237 238 .navigation-item-help > .navigation-bar > .item {238 .navigation-item-help > .navigation-bar > .item.button { 239 239 height: 100%; 240 padding: 0 4px !important;241 240 font-size: 11px; 242 241 border-radius: 4px; 242 border: solid 1px var(--border-color); 243 } 244 245 .navigation-item-help > .navigation-bar > .item.button:not(.text-only) { 246 padding: 0 4px !important; 247 } 248 249 /* Note: this is necessary due to the specificity of `.navigation-bar .item.button.text-only` */ 250 .navigation-item-help > .navigation-bar > .item.button.text-only { 243 251 border: solid 1px var(--border-color); 244 252 }
Note: See TracChangeset
for help on using the changeset viewer.