Changeset 265034 in webkit

Timestamp:

Jul 29, 2020 1:32:59 AM (4 years ago)

Author:

ysuzuki@apple.com

Message:

[JSC] Reflect object should have toStringTag with "Reflect"
​https://bugs.webkit.org/show_bug.cgi?id=214909

Reviewed by Mark Lam.

JSTests:

• stress/reflect.js:
• test262/expectations.yaml:

Source/JavaScriptCore:

We call JSC_TO_STRING_TAG_WITHOUT_TRANSITION in ReflectObject to set "Reflect" @@toStringTag, which fixes one test262 failure.

• runtime/ReflectObject.cpp:

(JSC::ReflectObject::finishCreation):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/reflect.js (modified) (1 diff)
• JSTests/test262/expectations.yaml (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/ReflectObject.cpp (modified) (2 diffs)

trunk/JSTests/ChangeLog

@@ +1 @@
+2020-07-29  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Reflect object should have toStringTag with "Reflect"
+        https://bugs.webkit.org/show_bug.cgi?id=214909
+
+        Reviewed by Mark Lam.
+
+        * stress/reflect.js:
+        * test262/expectations.yaml:
+
 2020-07-28  Caitlin Potter  <caitp@igalia.com>
 

trunk/JSTests/stress/reflect.js

@@ -7 +7 @@
 shouldBe(Reflect, Reflect);
 shouldBe(Object.getPrototypeOf(Reflect), Object.getPrototypeOf({}));
-shouldBe(Reflect.toString(), "[object Object]");
+shouldBe(Reflect.toString(), "[object Reflect]");
 shouldBe(Reflect.hasOwnProperty, Object.prototype.hasOwnProperty);

trunk/JSTests/test262/expectations.yaml

@@ -986 +986 @@
   default: 'Test262Error: Expected [length, foo, 0, Symbol()] and [Symbol(), length, foo, 0] to have the same contents. '
   strict mode: 'Test262Error: Expected [length, foo, 0, Symbol()] and [Symbol(), length, foo, 0] to have the same contents. '
-test/built-ins/Reflect/Symbol.toStringTag.js:
-  default: 'Test262Error: obj should have an own property Symbol(Symbol.toStringTag)'
-  strict mode: 'Test262Error: obj should have an own property Symbol(Symbol.toStringTag)'
 test/built-ins/RegExp/property-escapes/generated/Alphabetic.js:
   default: 'Test262Error: `\p{Alphabetic}` should match U+001CFA (`ᳺ`)'

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-07-29  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Reflect object should have toStringTag with "Reflect"
+        https://bugs.webkit.org/show_bug.cgi?id=214909
+
+        Reviewed by Mark Lam.
+
+        We call JSC_TO_STRING_TAG_WITHOUT_TRANSITION in ReflectObject to set "Reflect" @@toStringTag, which fixes one test262 failure.
+
+        * runtime/ReflectObject.cpp:
+        (JSC::ReflectObject::finishCreation):
+
 2020-07-28  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/runtime/ReflectObject.cpp

@@ -51 +51 @@
 STATIC_ASSERT_IS_TRIVIALLY_DESTRUCTIBLE(ReflectObject);
 
-const ClassInfo ReflectObject::s_info = { "Object", &Base::s_info, &reflectObjectTable, nullptr, CREATE_METHOD_TABLE(ReflectObject) };
+const ClassInfo ReflectObject::s_info = { "Reflect", &Base::s_info, &reflectObjectTable, nullptr, CREATE_METHOD_TABLE(ReflectObject) };
 
 /* Source for ReflectObject.lut.h
@@ -80 +80 @@
     Base::finishCreation(vm);
     ASSERT(inherits(vm, info()));
+    JSC_TO_STRING_TAG_WITHOUT_TRANSITION();
 }