Changeset 265143 in webkit

Timestamp:

Jul 31, 2020 9:10:02 AM (4 years ago)

Author:

Jonathan Bedard

Message:

[webkitcorepy] Changes to Tools/Scripts/libraries should trigger EWS
​https://bugs.webkit.org/show_bug.cgi?id=214998
<rdar://problem/66355658>

Reviewed by Aakash Jain.

• BuildSlaveSupport/ews-build/steps.py:

(CheckPatchRelevance): Add Tools/Scripts/libraries.

• BuildSlaveSupport/ews-build/steps_unittest.py:

(TestCheckPatchRelevance.test_relevant_webkitpy_patch):
(TestCheckPatchRelevance.test_relevant_libraries_patch):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (1 diff)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -298 +298 @@
 
     webkitpy_paths = [
-        'Tools/Scripts/webkitpy/',
+        'Tools/Scripts/webkitpy',
+        'Tools/Scripts/libraries',
     ]
 

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -2302 +2302 @@
         self.setupStep(CheckPatchRelevance())
         self.setProperty('buildername', 'Windows-EWS')
+        self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
+        return self.runStep()
+
+    def test_relevant_webkitpy_patch(self):
+        CheckPatchRelevance._get_patch = lambda x: 'Sample patch; file: Tools/Scripts/webkitpy'
+        self.setupStep(CheckPatchRelevance())
+        self.setProperty('buildername', 'WebKitPy-Tests-EWS')
+        self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
+        return self.runStep()
+
+    def test_relevant_libraries_patch(self):
+        CheckPatchRelevance._get_patch = lambda x: 'Sample patch; file: Tools/Scripts/libraries'
+        self.setupStep(CheckPatchRelevance())
+        self.setProperty('buildername', 'WebKitPy-Tests-EWS')
         self.expectOutcome(result=SUCCESS, state_string='Patch contains relevant changes')
         return self.runStep()

trunk/Tools/ChangeLog

@@ +1 @@
+2020-07-31  Jonathan Bedard  <jbedard@apple.com>
+
+        [webkitcorepy] Changes to Tools/Scripts/libraries should trigger EWS
+        https://bugs.webkit.org/show_bug.cgi?id=214998
+        <rdar://problem/66355658>
+
+        Reviewed by Aakash Jain.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (CheckPatchRelevance): Add Tools/Scripts/libraries.
+        * BuildSlaveSupport/ews-build/steps_unittest.py:
+        (TestCheckPatchRelevance.test_relevant_webkitpy_patch):
+        (TestCheckPatchRelevance.test_relevant_libraries_patch):
+
 2020-07-31  Keith Miller  <keith_miller@apple.com>