Changeset 265175 in webkit


Ignore:
Timestamp:
Aug 1, 2020 6:40:58 AM (4 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, reverting r265171.
​https://bugs.webkit.org/show_bug.cgi?id=215060

broke 2 mac api tests

Reverted changeset:

"[Mac] Add Experimental Feature preference for SW VP9"
​https://bugs.webkit.org/show_bug.cgi?id=215043
​https://trac.webkit.org/changeset/265171

Location:
trunk/Source/WebKit
Files:
11 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r265174 r265175  
     12020-08-01  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, reverting r265171.
     4        https://bugs.webkit.org/show_bug.cgi?id=215060
     5
     6        broke 2 mac api tests
     7
     8        Reverted changeset:
     9
     10        "[Mac] Add Experimental Feature preference for SW VP9"
     11        https://bugs.webkit.org/show_bug.cgi?id=215043
     12        https://trac.webkit.org/changeset/265171
     13
    1142020-08-01  Megan Gardner  <megan_gardner@apple.com>
    215

  • trunk/Source/WebKit/FeatureFlags/WebKit.plist

    r265171 r265175  
    5353        <true/>
    5454    </dict>
    55     <key>sw_vp9_decoder_on_battery</key>
    56     <dict>
    57         <key>Enabled</key>
    58         <false/>
    59     </dict>
    6055    <key>webm_parser</key>
    6156    <dict>

  • trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp

    r265171 r265175  
    155155    encoder << shouldRenderCanvasInGPUProcess;
    156156    encoder << shouldEnableVP9Decoder;
    157     encoder << shouldEnableVP9SWDecoder;
    158157    encoder << needsInAppBrowserPrivacyQuirks;
    159158    encoder << limitsNavigationsToAppBoundDomains;

  • trunk/Source/WebKit/Shared/WebPageCreationParameters.h

    r265171 r265175  
    228228    bool shouldRenderCanvasInGPUProcess { false };
    229229    bool shouldEnableVP9Decoder { false };
    230     bool shouldEnableVP9SWDecoder { false };
    231230    bool needsInAppBrowserPrivacyQuirks { false };
    232231    bool limitsNavigationsToAppBoundDomains { false };

  • trunk/Source/WebKit/Shared/WebPreferences.yaml

    r265171 r265175  
    670670  condition: ENABLE(VP9)
    671671
    672 VP9SWDecoderEnabledOnBattery:
    673   type: bool
    674   defaultValue: defaultVP9SWDecoderEnabledOnBattery()
    675   webcoreBinding: none
    676   humanReadableName: "VP9 SW decoder on battery"
    677   humanReadableDescription: "Enable VP9 SW decoder on battery"
    678   category: experimental
    679   condition: ENABLE(VP9)
    680 
    681672WebMParserEnabled:
    682673  type: bool

  • trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

    r265171 r265175  
    255255#endif
    256256
    257 #if ENABLE(VP9)
    258 bool defaultVP9SWDecoderEnabledOnBattery()
    259 {
    260 #if HAVE(SYSTEM_FEATURE_FLAGS)
    261     return isFeatureFlagEnabled("SW_vp9_decoder_on_battery");
    262 #endif
    263 
    264     return false;
    265 }
    266 #endif
    267 
    268257#if ENABLE(MEDIA_SOURCE) && ENABLE(VP9)
    269258bool defaultWebMParserEnabled()

  • trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h

    r265171 r265175  
    365365#if ENABLE(VP9)
    366366bool defaultVP9DecoderEnabled();
    367 bool defaultVP9SWDecoderEnabledOnBattery();
    368367#endif
    369368

  • trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

    r265171 r265175  
    212212#include <WebCore/AttributedString.h>
    213213#include <WebCore/RunLoopObserver.h>
    214 #include <WebCore/SystemBattery.h>
    215214#include <WebCore/TextIndicatorWindow.h>
    216215#include <wtf/MachSendRight.h>
    … …  
    78677866    parameters.shouldRenderCanvasInGPUProcess = preferences().renderCanvasInGPUProcessEnabled();
    78687867    parameters.shouldEnableVP9Decoder = preferences().vp9DecoderEnabled();
    7869 #if PLATFORM(COCOA)
    7870     parameters.shouldEnableVP9SWDecoder = preferences().vp9DecoderEnabled() && (!WebCore::systemHasBattery() || preferences().vp9SWDecoderEnabledOnBattery());
    7871 #endif
    78727868    parameters.shouldCaptureDisplayInUIProcess = m_process->processPool().configuration().shouldCaptureDisplayInUIProcess();
    78737869    parameters.limitsNavigationsToAppBoundDomains = m_limitsNavigationsToAppBoundDomains;

  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

    r265171 r265175  
    781781        WebProcess::singleton().enableVP9Decoder();
    782782
    783     if (parameters.shouldEnableVP9SWDecoder)
    784         WebProcess::singleton().enableVP9SWDecoder();
    785 
    786783    updateThrottleState();
    787784}

  • trunk/Source/WebKit/WebProcess/WebProcess.cpp

    r265171 r265175  
    19681968}
    19691969
    1970 void WebProcess::enableVP9SWDecoder()
    1971 {
    1972     if (m_vp9SWDecoderEnabled)
    1973         return;
    1974 
    1975     m_vp9SWDecoderEnabled = true;
    1976     LibWebRTCProvider::registerWebKitVP9Decoder();
    1977 }
    1978 
    19791970} // namespace WebKit
    19801971

  • trunk/Source/WebKit/WebProcess/WebProcess.h

    r265171 r265175  
    334334
    335335    void enableVP9Decoder();
    336     void enableVP9SWDecoder();
    337336
    338337private:
    … …  
    652651    bool m_useGPUProcessForMedia { false };
    653652    bool m_vp9DecoderEnabled { false };
    654     bool m_vp9SWDecoderEnabled { false };
    655653};
    656654
Note: See TracChangeset for help on using the changeset viewer.