Changeset 266408 in webkit
- Timestamp:
- Sep 1, 2020 12:24:21 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 51 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r266403 r266408 1 2020-09-01 Rob Buis <rbuis@igalia.com> 2 3 Convert runtime flag to setting for lazy image loading 4 https://bugs.webkit.org/show_bug.cgi?id=215610 5 6 Reviewed by Youenn Fablet. 7 8 Enable lazy image loading setting in resources/testharnessreport.js. Update test expectations 9 and adjust the tests in http/tests/lazyload/ to enable the setting. Fow WK1 list more tests 10 that should be skipped. 11 12 13 * TestExpectations: 14 * http/tests/lazyload/attribute.html: 15 * http/tests/lazyload/js-image.html: 16 * http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html: 17 * http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html: 18 * http/tests/lazyload/lazy.html: 19 * platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: 20 * platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: 21 * platform/mac-wk1/TestExpectations: 22 * platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: 23 * platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: 24 * platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt: 25 * resources/testharnessreport.js: 26 1 27 2020-09-01 Antti Koivisto <antti@apple.com> 2 28 -
trunk/LayoutTests/TestExpectations
r266396 r266408 551 551 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/adopt-from-image-document.html [ ImageOnlyFailure ] 552 552 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow-aspect-ratio.html [ ImageOnlyFailure ] 553 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html [ Skip ] 553 554 imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/dynamic-content-change-rendering.html [ ImageOnlyFailure ] 554 555 imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/reset-algorithm-rendering.html [ ImageOnlyFailure ] … … 575 576 imported/w3c/web-platform-tests/html/rendering/replaced-elements/attributes-for-embedded-content-and-images/img-aspect-ratio-lazy.tentative.html [ Failure Pass ] 576 577 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-to-eager.tentative.html [ Failure Pass ] 577 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager.html [ Failure Pass ]578 578 imported/w3c/web-platform-tests/html/semantics/forms/autofocus/update-the-rendering.html [ Failure Pass ] 579 579 imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/muted-errors.sub.html [ Failure Pass ] -
trunk/LayoutTests/http/tests/lazyload/attribute.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <script src="/resources/testharness.js"></script> 3 3 <script src="/resources/testharnessreport.js"></script> 4 4 <script src="placeholder.js"></script> 5 6 <script> 7 if (window.internals) 8 internals.settings.setLazyImageLoadingEnabled(true); 9 </script> 5 10 6 11 <body> -
trunk/LayoutTests/http/tests/lazyload/js-image.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <script src="/resources/testharness.js"></script> 3 3 <script src="/resources/testharnessreport.js"></script> … … 9 9 10 10 <script> 11 if (window.internals) 12 internals.settings.setLazyImageLoadingEnabled(true); 11 13 async_test(function(t) { 12 14 const img = new Image(); -
trunk/LayoutTests/http/tests/lazyload/lazy-image-load-in-iframes-scripting-disabled.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <script src="/resources/testharness.js"></script> 3 3 <script src="/resources/testharnessreport.js"></script> 4 4 <script src="placeholder.js"></script> 5 5 <script> 6 if (window.internals) 7 internals.settings.setLazyImageLoadingEnabled(true); 6 8 var t = async_test("Verify that iframe's with scripting off disallow lazy image loading."); 7 9 function finish() { -
trunk/LayoutTests/http/tests/lazyload/lazy-image-load-in-iframes-scripting-enabled.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <script src="/resources/testharness.js"></script> 3 3 <script src="/resources/testharnessreport.js"></script> 4 4 <script src="placeholder.js"></script> 5 5 <script> 6 if (window.internals) 7 internals.settings.setLazyImageLoadingEnabled(true); 6 8 var t = async_test("Verify that iframe's with sandbox='allow-scripts' allow lazy image loading."); 7 9 function finish() { -
trunk/LayoutTests/http/tests/lazyload/lazy.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <script src="/resources/testharness.js"></script> 3 3 <script src="/resources/testharnessreport.js"></script> 4 4 <script src="placeholder.js"></script> 5 6 <script> 7 if (window.internals) 8 internals.settings.setLazyImageLoadingEnabled(true); 9 </script> 5 10 6 11 <body> -
trunk/LayoutTests/imported/w3c/ChangeLog
r266399 r266408 1 2020-09-01 Rob Buis <rbuis@igalia.com> 2 3 Convert runtime flag to setting for lazy image loading 4 https://bugs.webkit.org/show_bug.cgi?id=215610 5 6 Reviewed by Youenn Fablet. 7 8 Remove changes done to the lazy image loading tests as we enable the setting in testharnessreport.js. 9 The new expected results are improvements. 10 11 * web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html: 12 * web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html: 13 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html: 14 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt: 15 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt: 16 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html: 17 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html: 18 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt: 19 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt: 20 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html: 21 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html: 22 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html: 23 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html: 24 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html: 25 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html: 26 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt: 27 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html: 28 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt: 29 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt: 30 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt: 31 * web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html: 32 * web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html: 33 * web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html: 34 * web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html: 35 * web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html: 36 * web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html: 37 * web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html: 38 1 39 2020-09-01 Alex Christensen <achristensen@webkit.org> 2 40 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/below-viewport-image-loading-lazy-load-event.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Below-viewport loading=lazy images do not block the window load event -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/disconnected-image-loading-lazy.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <script src="/resources/testharness.js"></script> 3 3 <script src="/resources/testharnessreport.js"></script> -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-eager.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Images with loading='eager' load immediately regardless of their -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-2-expected.txt
r266358 r266408 1 1 2 2 3 FAIL When a loading=lazy image is loaded, it loads relative to the document's base URL computed at parse-time. assert_true: Below-viewport loading=lazy images do not block the window load event expected true got false 3 PASS When a loading=lazy image is loaded, it loads relative to the document's base URL computed at parse-time. 4 4 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-base-url-expected.txt
r266358 r266408 1 1 2 2 3 FAIL When a loading=lazy image is loaded, it loads relative to the document's base URL computed at parse-time. assert_true: Below-viewport loading=lazy images do not block the window load event expected true got false 3 PASS When a loading=lazy image is loaded, it loads relative to the document's base URL computed at parse-time. 4 4 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-below-viewport-dynamic.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Below viewport images with loading='lazy' and changed to -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-crossorigin-change.sub.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Deferred images with loading='lazy' use the latest crossorigin attribute</title> -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-001.sub-expected.txt
r266358 r266408 1 1 2 2 3 FAILA below-viewport loading=lazy image in a cross origin iframe loads only4 when scrolled into viewport assert_equals: The loading=lazy image should not block the iframe's load event expected "window_loaded" but got "image_loaded"3 PASS A below-viewport loading=lazy image in a cross origin iframe loads only 4 when scrolled into viewport 5 5 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-cross-origin-iframe-002.sub-expected.txt
r266358 r266408 1 1 2 2 3 FAILA loading=lazy image in a below-viewport cross-origin iframe loads only4 when the cross-origin iframe is scrolled into view assert_equals: The loading=lazy image should not block the iframe's load event expected "window_loaded" but got "image_loaded"3 PASS A loading=lazy image in a below-viewport cross-origin iframe loads only 4 when the cross-origin iframe is scrolled into view 5 5 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-script-disabled-iframe.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Images with loading='lazy' in script disabled iframe are not handled -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-in-viewport-dynamic.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>In viewport images with loading='lazy' and changed to loading='eager' -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-load-event.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>In-viewport loading=lazy images do not block the window load event</title> -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-document.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Moving loading='lazy' image into another top level document</title> -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-move-into-script-disabled-iframe.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>A loading='lazy' image starts loading when the element is moved into -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multicol.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Images with loading='lazy' load when in the viewport</title> -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-multiple-times-expected.txt
r266358 r266408 1 1 2 2 3 FAIL Images with loading='lazy' can be lazy loaded multiple times assert_ true: The loading=lazy below-viewport image should not block the window load event expected true got false3 FAIL Images with loading='lazy' can be lazy loaded multiple times assert_unreached: The loading=lazy below-viewport image should lazily load its second image, and not load it eagerly when the `src` attribute is changed Reached unreachable code 4 4 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-referrerpolicy-change.sub.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Deferred loading=lazy images are fetched with the latest -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-relevant-mutations-expected.txt
r266358 r266408 1 CONSOLE MESSAGE: Error: assert_false: below-viewport-1 image should never load expected false got true 2 1 3 2 4 Harness Error (FAIL), message = Error: assert_false: below-viewport-1 image should never load expected false got true 3 PASS Images are lazyloaded 4 PASS Image referrerPolicy mutation does not cause deferred loading=lazy images to be fetched 5 PASS Image crossOrigin mutation does not cause deferred loading=lazy images to be fetched 6 PASS Image src mutation does not cause deferred loading=lazy images to be fetched 5 7 6 TIMEOUT Images are lazyloaded Test timed out7 NOTRUN Image referrerPolicy mutation does not cause deferred loading=lazy images to be fetched8 NOTRUN Image crossOrigin mutation does not cause deferred loading=lazy images to be fetched9 NOTRUN Image src mutation does not cause deferred loading=lazy images to be fetched10 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html
r266358 r266408 5 5 <link rel="help" href="https://html.spec.whatwg.org/multipage/#the-img-element"> 6 6 7 <script src="/resources/testharness.js"></script> 8 <script src="/resources/testharnessreport.js"></script> 7 9 <script src="/common/reftest-wait.js"></script> 8 10 <img id=target loading="lazy" -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-srcset-expected.txt
r266358 r266408 1 1 2 2 3 FAIL loading='lazy' image with srcset assert_equals: lazy-load images with srcset shouldn't be loaded yet expected 0 but got 2 3 PASS loading='lazy' image with srcset 4 4 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager-expected.txt
r266358 r266408 1 1 2 2 3 FAIL Below-viewport images with loading='lazy' load when set to loading='eager' or the `loading` attribute is removed assert_unreached: #img_1 should not load before the window load event Reached unreachable code 3 PASS Below-viewport images with loading='lazy' load when set to loading='eager' or the `loading` attribute is removed 4 4 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Images with loading='lazy' load only when in the viewport</title> -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Test that below-viewport invisible images that are not marked -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/move-element-and-scroll.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Images with loading='lazy' load being moved to another document -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-below-viewport-image-loading-lazy.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Below-viewport loading=lazy not-rendered images should never load, -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/not-rendered-image-loading-lazy.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>In-viewport loading=lazy not-rendered images should never load</title> -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Images with loading='lazy' in picture elements load when near the viewport</title> -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html
r266358 r266408 1 <!DOCTYPE html> <!-- webkit-test-runner [ experimental:enableLazyImageLoading=true ] -->1 <!DOCTYPE html> 2 2 <head> 3 3 <title>Images with loading='lazy' load being removed and then scrolled to</title> -
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
r266358 r266408 901 901 PASS HTMLImageElement interface: attribute referrerPolicy 902 902 PASS HTMLImageElement interface: attribute decoding 903 FAIL HTMLImageElement interface: attribute loading assert_true: The prototype object must have a property "loading" expected true got false 903 PASS HTMLImageElement interface: attribute loading 904 904 PASS HTMLImageElement interface: operation decode() 905 905 PASS HTMLImageElement interface: attribute name … … 927 927 PASS HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type 928 928 PASS HTMLImageElement interface: document.createElement("img") must inherit property "decoding" with the proper type 929 FAIL HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain 929 PASS HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type 930 930 PASS HTMLImageElement interface: document.createElement("img") must inherit property "decode()" with the proper type 931 931 PASS HTMLImageElement interface: document.createElement("img") must inherit property "name" with the proper type … … 953 953 PASS HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type 954 954 PASS HTMLImageElement interface: new Image() must inherit property "decoding" with the proper type 955 FAIL HTMLImageElement interface: new Image() must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain 955 PASS HTMLImageElement interface: new Image() must inherit property "loading" with the proper type 956 956 PASS HTMLImageElement interface: new Image() must inherit property "decode()" with the proper type 957 957 PASS HTMLImageElement interface: new Image() must inherit property "name" with the proper type -
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
r266358 r266408 901 901 PASS HTMLImageElement interface: attribute referrerPolicy 902 902 PASS HTMLImageElement interface: attribute decoding 903 FAIL HTMLImageElement interface: attribute loading assert_true: The prototype object must have a property "loading" expected true got false 903 PASS HTMLImageElement interface: attribute loading 904 904 PASS HTMLImageElement interface: operation decode() 905 905 PASS HTMLImageElement interface: attribute name … … 927 927 PASS HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type 928 928 PASS HTMLImageElement interface: document.createElement("img") must inherit property "decoding" with the proper type 929 FAIL HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain 929 PASS HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type 930 930 PASS HTMLImageElement interface: document.createElement("img") must inherit property "decode()" with the proper type 931 931 PASS HTMLImageElement interface: document.createElement("img") must inherit property "name" with the proper type … … 953 953 PASS HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type 954 954 PASS HTMLImageElement interface: new Image() must inherit property "decoding" with the proper type 955 FAIL HTMLImageElement interface: new Image() must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain 955 PASS HTMLImageElement interface: new Image() must inherit property "loading" with the proper type 956 956 PASS HTMLImageElement interface: new Image() must inherit property "decode()" with the proper type 957 957 PASS HTMLImageElement interface: new Image() must inherit property "name" with the proper type -
trunk/LayoutTests/platform/mac-wk1/TestExpectations
r266382 r266408 180 180 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/picture-loading-lazy.html [ Skip ] 181 181 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/remove-element-and-scroll.html [ Skip ] 182 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/invisible-image.html [ Skip ] 183 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-to-eager.html [ Skip ] 182 184 183 185 # testRunner.queueLoad() does not support loading data URLs in Mac WK1 -
trunk/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
r266358 r266408 901 901 PASS HTMLImageElement interface: attribute referrerPolicy 902 902 PASS HTMLImageElement interface: attribute decoding 903 FAIL HTMLImageElement interface: attribute loading assert_true: The prototype object must have a property "loading" expected true got false 903 PASS HTMLImageElement interface: attribute loading 904 904 PASS HTMLImageElement interface: operation decode() 905 905 PASS HTMLImageElement interface: attribute name … … 927 927 PASS HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type 928 928 PASS HTMLImageElement interface: document.createElement("img") must inherit property "decoding" with the proper type 929 FAIL HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain 929 PASS HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type 930 930 PASS HTMLImageElement interface: document.createElement("img") must inherit property "decode()" with the proper type 931 931 PASS HTMLImageElement interface: document.createElement("img") must inherit property "name" with the proper type … … 953 953 PASS HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type 954 954 PASS HTMLImageElement interface: new Image() must inherit property "decoding" with the proper type 955 FAIL HTMLImageElement interface: new Image() must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain 955 PASS HTMLImageElement interface: new Image() must inherit property "loading" with the proper type 956 956 PASS HTMLImageElement interface: new Image() must inherit property "decode()" with the proper type 957 957 PASS HTMLImageElement interface: new Image() must inherit property "name" with the proper type -
trunk/LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
r266358 r266408 901 901 PASS HTMLImageElement interface: attribute referrerPolicy 902 902 PASS HTMLImageElement interface: attribute decoding 903 FAIL HTMLImageElement interface: attribute loading assert_true: The prototype object must have a property "loading" expected true got false 903 PASS HTMLImageElement interface: attribute loading 904 904 PASS HTMLImageElement interface: operation decode() 905 905 PASS HTMLImageElement interface: attribute name … … 927 927 PASS HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type 928 928 PASS HTMLImageElement interface: document.createElement("img") must inherit property "decoding" with the proper type 929 FAIL HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain 929 PASS HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type 930 930 PASS HTMLImageElement interface: document.createElement("img") must inherit property "decode()" with the proper type 931 931 PASS HTMLImageElement interface: document.createElement("img") must inherit property "name" with the proper type … … 953 953 PASS HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type 954 954 PASS HTMLImageElement interface: new Image() must inherit property "decoding" with the proper type 955 FAIL HTMLImageElement interface: new Image() must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain 955 PASS HTMLImageElement interface: new Image() must inherit property "loading" with the proper type 956 956 PASS HTMLImageElement interface: new Image() must inherit property "decode()" with the proper type 957 957 PASS HTMLImageElement interface: new Image() must inherit property "name" with the proper type -
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
r266358 r266408 901 901 PASS HTMLImageElement interface: attribute referrerPolicy 902 902 PASS HTMLImageElement interface: attribute decoding 903 FAIL HTMLImageElement interface: attribute loading assert_true: The prototype object must have a property "loading" expected true got false 903 PASS HTMLImageElement interface: attribute loading 904 904 PASS HTMLImageElement interface: operation decode() 905 905 PASS HTMLImageElement interface: attribute name … … 927 927 PASS HTMLImageElement interface: document.createElement("img") must inherit property "referrerPolicy" with the proper type 928 928 PASS HTMLImageElement interface: document.createElement("img") must inherit property "decoding" with the proper type 929 FAIL HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain 929 PASS HTMLImageElement interface: document.createElement("img") must inherit property "loading" with the proper type 930 930 PASS HTMLImageElement interface: document.createElement("img") must inherit property "decode()" with the proper type 931 931 PASS HTMLImageElement interface: document.createElement("img") must inherit property "name" with the proper type … … 953 953 PASS HTMLImageElement interface: new Image() must inherit property "referrerPolicy" with the proper type 954 954 PASS HTMLImageElement interface: new Image() must inherit property "decoding" with the proper type 955 FAIL HTMLImageElement interface: new Image() must inherit property "loading" with the proper type assert_inherits: property "loading" not found in prototype chain 955 PASS HTMLImageElement interface: new Image() must inherit property "loading" with the proper type 956 956 PASS HTMLImageElement interface: new Image() must inherit property "decode()" with the proper type 957 957 PASS HTMLImageElement interface: new Image() must inherit property "name" with the proper type -
trunk/LayoutTests/resources/testharnessreport.js
r266358 r266408 31 31 if (window.webkitAudioPannerNode && !window.PannerNode) 32 32 Object.defineProperty(self, "PannerNode", Object.getOwnPropertyDescriptor(self, "webkitAudioPannerNode")); 33 if (self.internals) 33 if (self.internals) { 34 34 internals.settings.setLazyIframeLoadingEnabled(location.pathname.indexOf('iframe-loading-lazy') !== -1); 35 internals.settings.setLazyImageLoadingEnabled(true); 36 } 35 37 } 36 38 -
trunk/Source/WebCore/ChangeLog
r266407 r266408 1 2020-09-01 Rob Buis <rbuis@igalia.com> 2 3 Convert runtime flag to setting for lazy image loading 4 https://bugs.webkit.org/show_bug.cgi?id=215610 5 6 Reviewed by Youenn Fablet. 7 8 Convert runtime flag to setting for lazy image loading. Settings are 9 preferred over RuntimeEnabledFeatures as they are not global singletons 10 and are automatically accessible in layout tests via InternalSettingsGenerated. 11 12 * loader/ImageLoader.cpp: 13 1 14 2020-09-01 Tim Horton <timothy_horton@apple.com> 2 15 -
trunk/Source/WebCore/loader/ImageLoader.cpp
r266360 r266408 44 44 #include "RenderImage.h" 45 45 #include "RenderSVGImage.h" 46 #include " RuntimeEnabledFeatures.h"46 #include "Settings.h" 47 47 #include <wtf/NeverDestroyed.h> 48 48 -
trunk/Source/WebKit/ChangeLog
r266407 r266408 1 2020-09-01 Rob Buis <rbuis@igalia.com> 2 3 Convert runtime flag to setting for lazy image loading 4 https://bugs.webkit.org/show_bug.cgi?id=215610 5 6 Reviewed by Youenn Fablet. 7 8 Remove lazy image loading runtime flag. 9 10 * UIProcess/API/C/WKPreferences.cpp: 11 (WKPreferencesSetLazyImageLoadingEnabled): Deleted. 12 (WKPreferencesGetLazyImageLoadingEnabled): Deleted. 13 * UIProcess/API/C/WKPreferencesRefPrivate.h: 14 1 15 2020-09-01 Tim Horton <timothy_horton@apple.com> 2 16 -
trunk/Source/WebKit/UIProcess/API/C/WKPreferences.cpp
r266358 r266408 2231 2231 } 2232 2232 2233 void WKPreferencesSetLazyImageLoadingEnabled(WKPreferencesRef preferencesRef, bool flag)2234 {2235 toImpl(preferencesRef)->setLazyImageLoadingEnabled(flag);2236 }2237 2238 bool WKPreferencesGetLazyImageLoadingEnabled(WKPreferencesRef preferencesRef)2239 {2240 return toImpl(preferencesRef)->lazyImageLoadingEnabled();2241 }2242 2243 2233 bool WKPreferencesGetRemotePlaybackEnabled(WKPreferencesRef preferencesRef) 2244 2234 { -
trunk/Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h
r266358 r266408 616 616 WK_EXPORT bool WKPreferencesGetReferrerPolicyAttributeEnabled(WKPreferencesRef); 617 617 618 // Defaults to false619 WK_EXPORT void WKPreferencesSetLazyImageLoadingEnabled(WKPreferencesRef, bool flag);620 WK_EXPORT bool WKPreferencesGetLazyImageLoadingEnabled(WKPreferencesRef);621 622 618 #ifdef __cplusplus 623 619 } -
trunk/Tools/ChangeLog
r266399 r266408 1 2020-09-01 Rob Buis <rbuis@igalia.com> 2 3 Convert runtime flag to setting for lazy image loading 4 https://bugs.webkit.org/show_bug.cgi?id=215610 5 6 Reviewed by Youenn Fablet. 7 8 Remove lazy image loading runtime flag. 9 10 * WebKitTestRunner/TestController.cpp: 11 (WTR::TestController::resetPreferencesToConsistentValues): 12 (WTR::updateTestOptionsFromTestHeader): 13 * WebKitTestRunner/TestOptions.h: 14 (WTR::TestOptions::hasSameInitializationOptions const): 15 1 16 2020-09-01 Alex Christensen <achristensen@webkit.org> 2 17 -
trunk/Tools/WebKitTestRunner/TestController.cpp
r266358 r266408 922 922 WKPreferencesSetPunchOutWhiteBackgroundsInDarkMode(preferences, options.punchOutWhiteBackgroundsInDarkMode); 923 923 WKPreferencesSetPageCacheEnabled(preferences, options.enableBackForwardCache); 924 WKPreferencesSetLazyImageLoadingEnabled(preferences, options.enableLazyImageLoading);925 924 926 925 static WKStringRef defaultTextEncoding = WKStringCreateWithUTF8CString("ISO-8859-1"); … … 1552 1551 else if (key == "enableBackForwardCache") 1553 1552 testOptions.enableBackForwardCache = parseBooleanTestHeaderValue(value); 1554 else if (key == "enableLazyImageLoading")1555 testOptions.enableLazyImageLoading = parseBooleanTestHeaderValue(value);1556 1553 else if (key == "allowsLinkPreview") 1557 1554 testOptions.allowsLinkPreview = parseBooleanTestHeaderValue(value); -
trunk/Tools/WebKitTestRunner/TestOptions.h
r266358 r266408 97 97 bool enableAppNap { false }; 98 98 bool enableBackForwardCache { false }; 99 bool enableLazyImageLoading { false };100 99 bool allowsLinkPreview { true }; 101 100 bool enableCaptureVideoInUIProcess { false }; … … 166 165 || enableAppNap != options.enableAppNap 167 166 || enableBackForwardCache != options.enableBackForwardCache 168 || enableLazyImageLoading != options.enableLazyImageLoading169 167 || allowsLinkPreview != options.allowsLinkPreview 170 168 || enableCaptureVideoInUIProcess != options.enableCaptureVideoInUIProcess
Note: See TracChangeset
for help on using the changeset viewer.