Changeset 266799 in webkit

Timestamp:

Sep 9, 2020 2:30:35 PM (4 years ago)

Author:

aakash_jain@apple.com

Message:

ews might mark build as successful if tests fail to run
​https://bugs.webkit.org/show_bug.cgi?id=215944

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeLayoutTestsResults.retry_build):
(AnalyzeLayoutTestsResults.start):

• BuildSlaveSupport/ews-build/steps_unittest.py:

(TestAnalyzeLayoutTestsResults.test_test_fail_to_runs):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -2167 +2167 @@
     def retry_build(self, message=''):
         self.finished(RETRY)
-        message = 'Unable to confirm if test failures are introduced by patch, retrying build'
+        if not message:
+            message = 'Unable to confirm if test failures are introduced by patch, retrying build'
         self.descriptionDone = message
         self.build.buildFinished([message], RETRY)
@@ -2242 +2243 @@
         clean_tree_results_failing_tests = set(self.getProperty('clean_tree_run_failures', []))
         flaky_failures = first_results_failing_tests.union(second_results_failing_tests) - first_results_failing_tests.intersection(second_results_failing_tests)
+
+        if (not first_results_failing_tests) and (not second_results_failing_tests):
+            # If we've made it here, then layout-tests and re-run-layout-tests failed, which means
+            # there should have been some test failures. Otherwise there is some unexpected issue.
+            # TODO: email EWS admins
+            return self.retry_build('Unexpected infrastructure issue, retrying build')
 
         if first_results_did_exceed_test_failure_limit and second_results_did_exceed_test_failure_limit:

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -2068 +2068 @@
         self.assertEqual(self.getProperty('build_finish_summary'), failure_message)
         return rc
+
+    def test_unexpected_infra_issue(self):
+        self.configureStep()
+        self.setProperty('first_run_failures', [])
+        self.setProperty('second_run_failures', [])
+        self.expectOutcome(result=RETRY, state_string='Unexpected infrastructure issue, retrying build (retry)')
+        return self.runStep()
+
 
 class TestCheckOutSpecificRevision(BuildStepMixinAdditions, unittest.TestCase):

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-09  Aakash Jain  <aakash_jain@apple.com>
+
+        ews might mark build as successful if tests fail to run
+        https://bugs.webkit.org/show_bug.cgi?id=215944
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeLayoutTestsResults.retry_build):
+        (AnalyzeLayoutTestsResults.start):
+        * BuildSlaveSupport/ews-build/steps_unittest.py:
+        (TestAnalyzeLayoutTestsResults.test_test_fail_to_runs):
+
 2020-09-09  Brady Eidson  <beidson@apple.com>