Changeset 266975 in webkit

Timestamp:

Sep 12, 2020 12:09:10 AM (4 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] REGRESSION(r266815): Several GTK API tests are timing out
​https://bugs.webkit.org/show_bug.cgi?id=216361

Reviewed by Adrian Perez de Castro.

Source/WebInspectorUI:

Add missing trailing ';'.

• UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

Tools:

Unskip tests that are now passing.

• TestWebKitAPI/glib/TestExpectations.json:

Location:

trunk

Files:

• Source/WebInspectorUI/ChangeLog (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/glib/TestExpectations.json (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] REGRESSION(r266815): Several GTK API tests are timing out
+        https://bugs.webkit.org/show_bug.cgi?id=216361
+
+        Reviewed by Adrian Perez de Castro.
+
+        Add missing trailing ';'.
+
+        * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
+
 2020-09-10  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js

@@ -355 +355 @@
 
             const defaultCollapsedSettingValue = true;
-            let identifier = `${options.identifier ?? title}-event-listener-section`
+            let identifier = `${options.identifier ?? title}-event-listener-section`;
             let section = new WI.DetailsSection(identifier, title, groups, optionsElement, defaultCollapsedSettingValue);
             section.element.classList.add("event-listener-section");

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] REGRESSION(r266815): Several GTK API tests are timing out
+        https://bugs.webkit.org/show_bug.cgi?id=216361
+
+        Reviewed by Adrian Perez de Castro.
+
+        Unskip tests that are now passing.
+
+        * TestWebKitAPI/glib/TestExpectations.json:
+
 2020-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/TestWebKitAPI/glib/TestExpectations.json

@@ -100 +100 @@
     "TestInspectorServer": {
         "expected": {"all": {"slow": true}}
-    },
-    "TestInspector": {
-        "subtests": {
-            "/webkit/WebKitWebInspector/custom-container-destroyed": {
-              "expected": {"gtk": {"status": ["TIMEOUT"], "bug": "webkit.org/b/216361"}}
-            },
-            "/webkit/WebKitWebInspector/manual-attach-detach": {
-              "expected": {"gtk": {"status": ["TIMEOUT"], "bug": "webkit.org/b/216361"}}
-            },
-            "/webkit/WebKitWebInspector/default": {
-              "expected": {"gtk": {"status": ["TIMEOUT"], "bug": "webkit.org/b/216361"}}
-            }
-        }
     },
     "TestWebKitFaviconDatabase": {