Changeset 267000 in webkit

Timestamp:

Sep 13, 2020 11:47:31 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Make CanvasRenderingContext2D functions parameters not default to undefined
​https://bugs.webkit.org/show_bug.cgi?id=216438

Patch by Rob Buis <​rbuis@igalia.com> on 2020-09-13
Reviewed by Sam Weinig.

Source/WebCore:

Some string parameters default to "undefined", however the code path is the same when
no default is given and implicitly a null string is passed, so remove the default
values.

• html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

Adjust expected test result.

• inspector/canvas/recording-2d-full-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/canvas/recording-2d-full-expected.txt (modified) (3 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/canvas/CanvasRenderingContext2D.idl (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-13  Rob Buis  <rbuis@igalia.com>
+
+        Make CanvasRenderingContext2D functions parameters not default to undefined
+        https://bugs.webkit.org/show_bug.cgi?id=216438
+
+        Reviewed by Sam Weinig.
+
+        Adjust expected test result.
+
+        * inspector/canvas/recording-2d-full-expected.txt:
+
 2020-09-12  Tyler Wilcock <twilco.o@protonmail.com>
 

trunk/LayoutTests/inspector/canvas/recording-2d-full-expected.txt

@@ -653 +653 @@
         2: executeFrameFunction
   48: (duration)
-    0: setCompositeOperation("undefined")
+    0: setCompositeOperation("")
       swizzleTypes: [String]
       trace:
@@ -703 +703 @@
         2: executeFrameFunction
   50: (duration)
-    0: setLineCap("undefined")
+    0: setLineCap("")
       swizzleTypes: [String]
       trace:
@@ -723 +723 @@
         2: executeFrameFunction
   52: (duration)
-    0: setLineJoin("undefined")
+    0: setLineJoin("")
       swizzleTypes: [String]
       trace:

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-13  Rob Buis  <rbuis@igalia.com>
+
+        Make CanvasRenderingContext2D functions parameters not default to undefined
+        https://bugs.webkit.org/show_bug.cgi?id=216438
+
+        Reviewed by Sam Weinig.
+
+        Some string parameters default to "undefined", however the code path is the same when
+        no default is given and implicitly a null string is passed, so remove the default
+        values.
+
+        * html/canvas/CanvasRenderingContext2D.idl:
+
 2020-09-13  Sam Weinig  <weinig@apple.com>
 

trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl

@@ -35 +35 @@
     // Non-standard legacy aliases (Compositing).
     [ImplementedAs=setGlobalAlpha] undefined setAlpha(optional unrestricted float alpha = NaN);
-    [ImplementedAs=setGlobalCompositeOperation] undefined setCompositeOperation(optional DOMString compositeOperation = "undefined"); // FIXME: Using "undefined" as default parameter value is wrong.
+    [ImplementedAs=setGlobalCompositeOperation] undefined setCompositeOperation(optional DOMString compositeOperation);
 
     // Non-standard functionality (CanvasDrawImage).
@@ -61 +61 @@
     // Non-standard legacy aliases (CanvasPathDrawingStyles).
     undefined setLineWidth(optional unrestricted float width = NaN);
-    undefined setLineCap(optional DOMString cap = "undefined"); // FIXME: Using "undefined" as default parameter value is wrong.
-    undefined setLineJoin(optional DOMString join = "undefined"); // FIXME: Using "undefined" as default parameter value is wrong.
+    undefined setLineCap(optional DOMString cap);
+    undefined setLineJoin(optional DOMString join);
     undefined setMiterLimit(optional unrestricted float limit = NaN);
     attribute sequence<unrestricted float> webkitLineDash;