Changeset 267066 in webkit

Timestamp:

Sep 14, 2020 6:59:20 PM (4 years ago)

Author:

Chris Dumez

Message:

Type of AnalyserNode's attributes should not be unrestricted double
​https://bugs.webkit.org/show_bug.cgi?id=216505

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing WPT test now that the exception message was improved.

• web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:

Source/WebCore:

Type of AnalyserNode's attributes should not be unrestricted double. They should use double type
so that we throw when trying to set them to NaN or infinity values.

No new tests, updated existing test.

• Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::setSmoothingTimeConstant):

• Modules/webaudio/AnalyserNode.idl:

LayoutTests:

Extend layout test coverage.

• webaudio/analyser-exception-expected.txt:
• webaudio/analyser-exception.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt (modified) (1 diff)
• LayoutTests/webaudio/analyser-exception-expected.txt (modified) (1 diff)
• LayoutTests/webaudio/analyser-exception.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webaudio/AnalyserNode.cpp (modified) (1 diff)
• Source/WebCore/Modules/webaudio/AnalyserNode.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-14  Chris Dumez  <cdumez@apple.com>
+
+        Type of AnalyserNode's attributes should not be unrestricted double
+        https://bugs.webkit.org/show_bug.cgi?id=216505
+
+        Reviewed by Darin Adler.
+
+        Extend layout test coverage.
+
+        * webaudio/analyser-exception-expected.txt:
+        * webaudio/analyser-exception.html:
+
 2020-09-14  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2020-09-14  Chris Dumez  <cdumez@apple.com>
+
+        Type of AnalyserNode's attributes should not be unrestricted double
+        https://bugs.webkit.org/show_bug.cgi?id=216505
+
+        Reviewed by Darin Adler.
+
+        Rebaseline existing WPT test now that the exception message was improved.
+
+        * web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt:
+
 2020-09-14  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/webaudio/the-audio-api/the-analysernode-interface/ctor-analyser-expected.txt

@@ -65 +65 @@
 PASS   node = new AnalyserNode(c, { maxDecibels: -500 }) threw IndexSizeError: "minDecibels must be less than maxDecibels.". 
 PASS   node = new AnalyserNode(c, { minDecibels: -10 }) threw IndexSizeError: "minDecibels must be less than maxDecibels.". 
-PASS   node = new AnalyserNode(c, { smoothingTimeConstant: 2 }) threw IndexSizeError: "The index is not in the allowed range.". 
+PASS   node = new AnalyserNode(c, { smoothingTimeConstant: 2 }) threw IndexSizeError: "Smoothing time constant needs to be between 0 and 1.". 
 PASS   node = new AnalyserNode(c, { frequencyBinCount: 33 }) did not throw an exception. 
 PASS   node.frequencyBinCount is equal to 1024. 

trunk/LayoutTests/webaudio/analyser-exception-expected.txt

@@ -4 +4 @@
 
 PASS analyser.minDecibels = -20 threw exception IndexSizeError: minDecibels must be less than maxDecibels..
+PASS analyser.minDecibels = NaN threw exception TypeError: The provided value is non-finite.
+PASS analyser.minDecibels = Infinity threw exception TypeError: The provided value is non-finite.
+PASS analyser.minDecibels = -Infinity threw exception TypeError: The provided value is non-finite.
 PASS analyser.maxDecibels = -120 threw exception IndexSizeError: maxDecibels must be greater than minDecibels..
-PASS analyser.smoothingTimeConstant = 2 threw exception IndexSizeError: The index is not in the allowed range..
+PASS analyser.maxDecibels = NaN threw exception TypeError: The provided value is non-finite.
+PASS analyser.maxDecibels = Infinity threw exception TypeError: The provided value is non-finite.
+PASS analyser.maxDecibels = -Infinity threw exception TypeError: The provided value is non-finite.
+PASS analyser.smoothingTimeConstant = 2 threw exception IndexSizeError: Smoothing time constant needs to be between 0 and 1..
+PASS analyser.smoothingTimeConstant = -1 threw exception IndexSizeError: Smoothing time constant needs to be between 0 and 1..
+PASS analyser.smoothingTimeConstant = NaN threw exception TypeError: The provided value is non-finite.
+PASS analyser.smoothingTimeConstant = Infinity threw exception TypeError: The provided value is non-finite.
+PASS analyser.smoothingTimeConstant = -Infinity threw exception TypeError: The provided value is non-finite.
 PASS successfullyParsed is true
 

trunk/LayoutTests/webaudio/analyser-exception.html

@@ -29 +29 @@
     // 'minDecibels' shouldn't be greater than 'maxDecibels' which defaults to -30dB.
     shouldThrowErrorName("analyser.minDecibels = -20", "IndexSizeError");
+    shouldThrowErrorName("analyser.minDecibels = NaN", "TypeError");
+    shouldThrowErrorName("analyser.minDecibels = Infinity", "TypeError");
+    shouldThrowErrorName("analyser.minDecibels = -Infinity", "TypeError");
 
     // 'maxDecibels' shouldn't be less than 'minDecibels' which defaults to -100dB.
     shouldThrowErrorName("analyser.maxDecibels = -120", "IndexSizeError");
+    shouldThrowErrorName("analyser.maxDecibels = NaN", "TypeError");
+    shouldThrowErrorName("analyser.maxDecibels = Infinity", "TypeError");
+    shouldThrowErrorName("analyser.maxDecibels = -Infinity", "TypeError");
 
     // 'smoothingTimeConstant' range is between 0 and 1.
     shouldThrowErrorName("analyser.smoothingTimeConstant = 2", "IndexSizeError");
+    shouldThrowErrorName("analyser.smoothingTimeConstant = -1", "IndexSizeError");
+    shouldThrowErrorName("analyser.smoothingTimeConstant = NaN", "TypeError");
+    shouldThrowErrorName("analyser.smoothingTimeConstant = Infinity", "TypeError");
+    shouldThrowErrorName("analyser.smoothingTimeConstant = -Infinity", "TypeError");
 
     context.oncomplete = finishJSTest;

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-14  Chris Dumez  <cdumez@apple.com>
+
+        Type of AnalyserNode's attributes should not be unrestricted double
+        https://bugs.webkit.org/show_bug.cgi?id=216505
+
+        Reviewed by Darin Adler.
+
+        Type of AnalyserNode's attributes should not be unrestricted double. They should use double type
+        so that we throw when trying to set them to NaN or infinity values.
+
+        No new tests, updated existing test.
+
+        * Modules/webaudio/AnalyserNode.cpp:
+        (WebCore::AnalyserNode::setSmoothingTimeConstant):
+        * Modules/webaudio/AnalyserNode.idl:
+
 2020-09-14  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/AnalyserNode.cpp

@@ -142 +142 @@
 {
     if (k < 0 || k > 1)
-        return Exception { IndexSizeError };
+        return Exception { IndexSizeError, "Smoothing time constant needs to be between 0 and 1."_s };
 
     m_analyser.setSmoothingTimeConstant(k);

trunk/Source/WebCore/Modules/webaudio/AnalyserNode.idl

@@ -33 +33 @@
 
     // minDecibels / maxDecibels represent the range to scale the FFT analysis data for conversion to unsigned byte values.
-    attribute unrestricted double minDecibels;
-    attribute unrestricted double maxDecibels;
+    attribute double minDecibels;
+    attribute double maxDecibels;
 
     // A value from 0.0 -> 1.0 where 0.0 represents no time averaging with the last analysis frame.
-    attribute unrestricted double smoothingTimeConstant;
+    attribute double smoothingTimeConstant;
 
     // Copies the current frequency data into the passed array.