Changeset 267071 in webkit


Ignore:
Timestamp:
Sep 14, 2020 8:31:34 PM (4 years ago)
Author:
Chris Dumez
Message:

Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float
​https://bugs.webkit.org/show_bug.cgi?id=216508

Reviewed by Darin Adler.

Source/WebCore:

Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float:

They should use float type so that we throw when passing values that are non-finite or not a number.

Test: webaudio/panner-node-exceptions.html

  • Modules/webaudio/PannerNode.idl:

LayoutTests:

Add layout test coverage.

  • webaudio/panner-node-exceptions-expected.txt: Added.
  • webaudio/panner-node-exceptions.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r267070 r267071  
     12020-09-14  Chris Dumez  <cdumez@apple.com>
     2
     3        Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float
     4        https://bugs.webkit.org/show_bug.cgi?id=216508
     5
     6        Reviewed by Darin Adler.
     7
     8        Add layout test coverage.
     9
     10        * webaudio/panner-node-exceptions-expected.txt: Added.
     11        * webaudio/panner-node-exceptions.html: Added.
     12
    1132020-09-14  Hector Lopez  <hector_i_lopez@apple.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r267069 r267071  
     12020-09-14  Chris Dumez  <cdumez@apple.com>
     2
     3        Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float
     4        https://bugs.webkit.org/show_bug.cgi?id=216508
     5
     6        Reviewed by Darin Adler.
     7
     8        Types of Panner.setPosition() / setOrientation() parameters should not be unrestricted float:
     9        - https://www.w3.org/TR/webaudio/#pannernode
     10
     11        They should use float type so that we throw when passing values that are non-finite or not a number.
     12
     13        Test: webaudio/panner-node-exceptions.html
     14
     15        * Modules/webaudio/PannerNode.idl:
     16
    1172020-09-14  Sam Weinig  <weinig@apple.com>
    218

  • trunk/Source/WebCore/Modules/webaudio/PannerNode.idl

    r267007 r267071  
    3434
    3535    // Uses a 3D cartesian coordinate system
    36     [MayThrowException] undefined setPosition(unrestricted float x, unrestricted float y, unrestricted float z);
    37     [MayThrowException] undefined setOrientation(unrestricted float x, unrestricted float y, unrestricted float z);
     36    [MayThrowException] undefined setPosition(float x, float y, float z);
     37    [MayThrowException] undefined setOrientation(float x, float y, float z);
    3838   
    3939    // Default distance model is inverse
Note: See TracChangeset for help on using the changeset viewer.