Changeset 267133 in webkit

Timestamp:

Sep 15, 2020 9:33:04 PM (4 years ago)

Author:

Alan Bujtas

Message:

[LFC] Use isBlockBox() in Box::establishesBlockFormattingContext
​https://bugs.webkit.org/show_bug.cgi?id=216595

Reviewed by Simon Fraser.

Let's use the Box::isBlockBox() function (now that we have it) to check if a box establishes a new BFC (this matches spec language now).

• layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::establishesBlockFormattingContext const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/layouttree/LayoutBox.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-15  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Use isBlockBox() in Box::establishesBlockFormattingContext
+        https://bugs.webkit.org/show_bug.cgi?id=216595
+
+        Reviewed by Simon Fraser.
+
+        Let's use the Box::isBlockBox() function (now that we have it) to check if a box establishes a new BFC (this matches spec language now).
+
+        * layout/layouttree/LayoutBox.cpp:
+        (WebCore::Layout::Box::establishesBlockFormattingContext const):
+
 2020-09-15  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/Source/WebCore/layout/layouttree/LayoutBox.cpp

@@ -96 +96 @@
     }
 
-    if (isBlockContainer() && !isBlockLevelBox())
-        return true;
-
-    if (isBlockLevelBox() && !isOverflowVisible())
+    if (isBlockContainer() && !isBlockBox())
+        return true;
+
+    if (isBlockBox() && !isOverflowVisible())
         return true;