Changeset 267136 in webkit

Timestamp:

Sep 15, 2020 11:22:53 PM (4 years ago)

Author:

commit-queue@webkit.org

Message:

Fix lazy image load painting
​https://bugs.webkit.org/show_bug.cgi?id=216554

Patch by Rob Buis <​rbuis@igalia.com> on 2020-09-15
Reviewed by Darin Adler.

Source/WebCore:

Fix lazy image load painting, when LoadImmediately was introduced, it correctly
triggered the immediate load but after finishing the load there was no transition
to the finished lazy load state, causing the logic in RenderImage::paint to not
paint the finished load. This was not detected before since most lazy load WPT tests are
not pixel tests but rather test correct load events etc. (image-loading-subpixel-clip.html
is an exception since it is a reftest).

Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::notifyFinished):

LayoutTests:

The test image-loading-subpixel-clip.html now passes.

• TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/loader/ImageLoader.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-15  Rob Buis  <rbuis@igalia.com>
+
+        Fix lazy image load painting
+        https://bugs.webkit.org/show_bug.cgi?id=216554
+
+        Reviewed by Darin Adler.
+
+        The test image-loading-subpixel-clip.html now passes.
+
+        * TestExpectations:
+
 2020-09-15  Karl Rackler  <rackler@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -551 +551 @@
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow-aspect-ratio.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-lazy-slow.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/html/semantics/forms/the-option-element/dynamic-content-change-rendering.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/reset-algorithm-rendering.html [ ImageOnlyFailure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-15  Rob Buis  <rbuis@igalia.com>
+
+        Fix lazy image load painting
+        https://bugs.webkit.org/show_bug.cgi?id=216554
+
+        Reviewed by Darin Adler.
+
+        Fix lazy image load painting, when LoadImmediately was introduced, it correctly
+        triggered the immediate load but after finishing the load there was no transition
+        to the finished lazy load state, causing the logic in RenderImage::paint to not
+        paint the finished load. This was not detected before since most lazy load WPT tests are
+        not pixel tests but rather test correct load events etc. (image-loading-subpixel-clip.html
+        is an exception since it is a reftest).
+
+        Test: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/image-loading-subpixel-clip.html
+
+        * loader/ImageLoader.cpp:
+        (WebCore::ImageLoader::notifyFinished):
+
 2020-09-15  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/loader/ImageLoader.cpp

@@ -329 +329 @@
     ASSERT_UNUSED(resource, &resource == m_image.get());
 
-    if (m_lazyImageLoadState == LazyImageLoadState::Deferred) {
+    if (isDeferred()) {
         LazyLoadImageObserver::unobserve(element(), element().document());
         m_lazyImageLoadState = LazyImageLoadState::FullImage;