Changeset 267151 in webkit

Timestamp:

Sep 16, 2020 10:06:49 AM (4 years ago)

Author:

Chris Dumez

Message:

OfflineAudioContext should support up to 32 channels
​https://bugs.webkit.org/show_bug.cgi?id=216587

Reviewed by Darin Adler.

Source/WebCore:

OfflineAudioContext should support up to 32 channels. It previously had
an artificial limit of 10.

No new tests, updated existing test.

• Modules/webaudio/OfflineAudioContext.cpp:

(WebCore::OfflineAudioContext::create):

LayoutTests:

Update test that is now passing.

• webaudio/dom-exceptions-expected.txt:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webaudio/dom-exceptions-expected.txt (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-16  Chris Dumez  <cdumez@apple.com>
+
+        OfflineAudioContext should support up to 32 channels
+        https://bugs.webkit.org/show_bug.cgi?id=216587
+
+        Reviewed by Darin Adler.
+
+        Update test that is now passing.
+
+        * webaudio/dom-exceptions-expected.txt:
+
 2020-09-16  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/webaudio/dom-exceptions-expected.txt

@@ -134 +134 @@
 PASS < [biquad] All assertions passed. (total 4 assertions) 
 PASS > [offline-audio-context] supports 32 channels 
-FAIL X new OfflineAudioContext(32, 100, context.sampleRate) incorrectly threw SyntaxError: "Number of channels is not in range". assert_true: expected true got false
-FAIL < [offline-audio-context] 1 out of 1 assertions were failed. assert_true: expected true got false
+PASS   new OfflineAudioContext(32, 100, context.sampleRate) did not throw an exception. 
+PASS < [offline-audio-context] All assertions passed. (total 1 assertions) 
 PASS > [invalid-offline-audio-context-parameters] errors for invalid channel counts 
 PASS   new OfflineAudioContext(0, 100, context.sampleRate) threw SyntaxError: "Number of channels is not in range". 
@@ -261 +261 @@
 PASS   source.noteOff is equal to undefined. 
 PASS < [misc] All assertions passed. (total 4 assertions) 
-FAIL # AUDIT TASK RUNNER FINISHED: 1 out of 24 tasks were failed. assert_true: expected true got false
+PASS # AUDIT TASK RUNNER FINISHED: 24 tasks ran successfully. 
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-09-16  Chris Dumez  <cdumez@apple.com>
+
+        OfflineAudioContext should support up to 32 channels
+        https://bugs.webkit.org/show_bug.cgi?id=216587
+
+        Reviewed by Darin Adler.
+
+        OfflineAudioContext should support up to 32 channels. It previously had
+        an artificial limit of 10.
+
+        No new tests, updated existing test.
+
+        * Modules/webaudio/OfflineAudioContext.cpp:
+        (WebCore::OfflineAudioContext::create):
+
 2020-09-16  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.cpp

@@ -49 +49 @@
     if (!is<Document>(context))
         return Exception { NotSupportedError };
-    if (!numberOfChannels || numberOfChannels > 10)
+    if (!numberOfChannels || numberOfChannels > maxNumberOfChannels())
         return Exception { SyntaxError, "Number of channels is not in range"_s };
     if (!length)