Changeset 267161 in webkit

Timestamp:

Sep 16, 2020 2:52:51 PM (4 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Improve failure summary string for AnalyzeCompileWebKitResults step
​https://bugs.webkit.org/show_bug.cgi?id=216566

Reviewed by Jonathan Bedard.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeCompileWebKitResults.analyzeResults): Move self.finished() after setting self.descriptionDone.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -1439 +1439 @@
 
         if compile_without_patch_result == FAILURE:
-            self.finished(FAILURE)
             message = 'Unable to build WebKit without patch, retrying build'
             self.descriptionDone = message
             self.send_email_for_preexisting_build_failure()
+            self.finished(FAILURE)
             self.build.buildFinished([message], RETRY)
             return defer.succeed(None)
 
-        self.finished(FAILURE)
         self.build.results = FAILURE
         patch_id = self.getProperty('patch_id', '')
@@ -1453 +1452 @@
 
         self.descriptionDone = message
+        self.finished(FAILURE)
         self.setProperty('build_finish_summary', message)
         if self.getProperty('buildername', '').lower() == 'commit-queue':

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-16  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Improve failure summary string for AnalyzeCompileWebKitResults step
+        https://bugs.webkit.org/show_bug.cgi?id=216566
+
+        Reviewed by Jonathan Bedard.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeCompileWebKitResults.analyzeResults): Move self.finished() after setting self.descriptionDone.
+
 2020-09-16  Philippe Normand  <pnormand@igalia.com>