Changeset 267162 in webkit

Timestamp:

Sep 16, 2020 2:56:04 PM (4 years ago)

Author:

jer.noble@apple.com

Message:

REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
​https://bugs.webkit.org/show_bug.cgi?id=216619

Reviewed by Chris Dumez.

Tools:

In r266844, we adopted an API which would cause audio decoding to be supressed when a media element is initially muted. WebKitTestRunner
calls a WebKit SPI to artificially mute all media elements within the page (because listening to LayoutTest beeps and boops is annoying)
which causes this code path to be hit for all media elements. Rather than muting the page, WKTR should do the same as DRT, and set the
output volume to zero.

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

• platform/mac-wk2/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/mac-wk2/TestExpectations (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/TestController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-09-16  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
+        https://bugs.webkit.org/show_bug.cgi?id=216619
+
+        Reviewed by Chris Dumez.
+
+        * platform/mac-wk2/TestExpectations:
+
 2020-09-16  Zalan Bujtas  <zalan@apple.com>
 

trunk/LayoutTests/platform/mac-wk2/TestExpectations

@@ -1317 +1317 @@
 [ BigSur+ ] http/tests/media/video-no-content-length-stall.html [ Failure ]
 
-# rdar://68743466 (REGRESSION: [ BigSur wk2 ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure)
-[ BigSur+ ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html [ Failure ]
-
 # rdar://68947260 (REGRESSION (r266634): [ BigSur wk2 ] fast/selectors/text-field-selection-window-inactive-stroke-color.html is a flaky image failure)
 fast/selectors/text-field-selection-window-inactive-stroke-color.html [ Pass ImageOnlyFailure ]

trunk/Tools/ChangeLog

@@ +1 @@
+2020-09-16  Jer Noble  <jer.noble@apple.com>
+
+        REGRESSION(r266844) [ BigSur ] http/tests/security/webaudio-render-remote-audio-allowed-crossorigin.html is a constant failure
+        https://bugs.webkit.org/show_bug.cgi?id=216619
+
+        Reviewed by Chris Dumez.
+
+        In r266844, we adopted an API which would cause audio decoding to be supressed when a media element is initially muted. WebKitTestRunner
+        calls a WebKit SPI to artificially mute all media elements within the page (because listening to LayoutTest beeps and boops is annoying)
+        which causes this code path to be hit for all media elements. Rather than muting the page, WKTR should do the same as DRT, and set the
+        output volume to zero.
+
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetStateToConsistentValues):
+
 2020-09-16  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/WebKitTestRunner/TestController.cpp

@@ -1100 +1100 @@
     WKPageClearWheelEventTestMonitor(m_mainWebView->page());
 
-    WKPageSetMuted(m_mainWebView->page(), true);
+    WKPageSetMediaVolume(m_mainWebView->page(), 0);
 
     WKPageClearUserMediaState(m_mainWebView->page());