Changeset 267517 in webkit
- Timestamp:
- Sep 23, 2020 9:33:24 PM (4 years ago)
- Location:
- trunk/Tools
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Tools/ChangeLog
r267511 r267517 1 2020-09-23 Antti Koivisto <antti@apple.com> 2 3 [Windows] Ignore render tree dump based results on Windows 4 https://bugs.webkit.org/show_bug.cgi?id=209897 5 6 Reviewed by Darin Adler. 7 8 Render tree dumps are port specific and so difficult to maintain. They are mostly very old and 9 have been superseded by more modern ref and text dump tests. They rarely reveal any port specific bugs. 10 11 This patch adds --ignore-render-tree-dump-results option to run-webkit-tests and enables it by 12 default on Apple Windows port. 13 14 With the option set the render tree dump tests are still run (so crashes are detected) but their 15 output is treated as if it always passed. Missing results are not written to disk. 16 17 * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: 18 (SingleTestRunner._compare_text): 19 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 20 (parse_args): 21 (_set_up_derived_options): 22 1 23 2020-09-23 Matt Lewis <jlewis3@apple.com> 2 24 -
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py
r265514 r267517 235 235 def _compare_text(self, expected_text, actual_text): 236 236 failures = [] 237 if self._options.ignore_render_tree_dump_results and actual_text and self._render_tree_dump_pattern.match(actual_text): 238 return failures 237 239 if (expected_text and actual_text and 238 240 # Assuming expected_text is already normalized. -
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py
r267479 r267517 152 152 optparse.make_option("--no-ref-tests", action="store_true", 153 153 dest="no_ref_tests", help="Skip all ref tests"), 154 optparse.make_option("--ignore-render-tree-dump-results", action="store_true", 155 dest="ignore_render_tree_dump_results", 156 help="Don't compare or save results for render tree dump tests (they still run and crashes are reported)"), 154 157 optparse.make_option("--tolerance", 155 158 help="Ignore image differences less than this percentage (some " … … 472 475 options.webkit_test_runner = True 473 476 477 # Don't maintain render tree dump results for Apple Windows port. 478 if port.port_name == "win": 479 options.ignore_render_tree_dump_results = True 480 474 481 if options.leaks: 475 482 options.additional_env_var.append("JSC_usePoisoning=0")
Note: See TracChangeset
for help on using the changeset viewer.