Changeset 267656 in webkit


Ignore:
Timestamp:
Sep 27, 2020 5:55:58 AM (4 years ago)
Author:
cathiechen
Message:

Add support to pause in testdriver.js
https://bugs.webkit.org/show_bug.cgi?id=216933

Reviewed by Darin Adler

While simulating a mouse action, pause in dispatchMouseActions() is needed. Otherwise, the events are sent
without delay, the simulation might not be effective. The patch uses JS setTimeout to simulate a pause.

  • web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-expected.txt:
  • web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt:
  • web-platform-tests/resources/testdriver-vendor.js:

(pause): Use setTimeout to simulate a pause.
(dispatchMouseActions):

Location:
trunk/LayoutTests/imported/w3c
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/imported/w3c/ChangeLog

    r267654 r267656  
     12020-09-27  Cathie Chen  <cathiechen@igalia.com>
     2
     3        Add support to pause in testdriver.js
     4        https://bugs.webkit.org/show_bug.cgi?id=216933
     5
     6        Reviewed by Darin Adler
     7
     8        While simulating a mouse action, pause in dispatchMouseActions() is needed. Otherwise, the events are sent
     9        without delay, the simulation might not be effective. The patch uses JS setTimeout to simulate a pause.
     10
     11        * web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-expected.txt:
     12        * web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt:
     13        * web-platform-tests/resources/testdriver-vendor.js:
     14        (pause): Use setTimeout to simulate a pause.
     15        (dispatchMouseActions):
     16
    1172020-09-27  Rob Buis  <rbuis@igalia.com>
    218
  • trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointerlock_supercedes_capture-expected.txt

    r264344 r267656  
    99
    1010
    11 FAIL mouse no pointercapture while pointerlock assert_equals: Pointer is unlocked expected 2 but got 0
     11FAIL mouse no pointercapture while pointerlock assert_greater_than: More than 1 pointermove has been received after unlocked expected a number greater than 1 but got 0
    1212
  • trunk/LayoutTests/imported/w3c/web-platform-tests/pointerevents/pointerlock/pointerevent_pointermove_on_chorded_mouse_button_when_locked-expected.txt

    r267647 r267656  
    1010Pointer Lock Pointer Events pointermove on button state changes Tests
    1111
    12 The following pointer types were detected: (none).
     12The following pointer types were detected: mouse.
    1313
    1414Refresh the page to run the tests again.
    1515
    1616
    17 Harness Error (TIMEOUT), message = null
     17PASS pointer locked pointermove events received for button state changes
    1818
    19 NOTRUN pointer locked pointermove events received for button state changes
    20 
  • trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js

    r258411 r267656  
    88}
    99
     10function pause(duration) {
     11    return new Promise(resolve => {
     12        setTimeout(() => {
     13            resolve();
     14        }, duration);
     15    });
     16}
     17
    1018function dispatchMouseActions(actions)
    1119{
     
    1422
    1523    return new Promise(resolve => {
    16         setTimeout(() => {
     24        setTimeout(async () => {
    1725            eventSender.dragMode = false;
    1826
     
    3947                    break;
    4048                case "pause":
    41                     // FIXME: What should we do here?
     49                    logDebug(() => `pause(${action.duration})`);
     50                    await pause(action.duration);
    4251                    break;
    4352                default:
Note: See TracChangeset for help on using the changeset viewer.