Changeset 268308 in webkit


Ignore:
Timestamp:
Oct 9, 2020 9:37:25 PM (3 years ago)
Author:
jer.noble@apple.com
Message:

[Mac] AirPlay menu does not show up when AirPlay button is clicked
https://bugs.webkit.org/show_bug.cgi?id=217536
<rdar://problem/69973777>

Reviewed by Eric Carlson.

Source/WebCore:

PAL tries to soft-link the AVRoutePickerView from the AVFoundation framework, rather than the (correct)
AVKit framework. Remove AVRoutePickerView from AVFoundationSoftLink.h and use the already declared version
inside AVRoutePickerViewTargetPicker.mm.

  • platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm:

(WebCore::AVRoutePickerViewTargetPicker::isAvailable):

Source/WebCore/PAL:

  • pal/cocoa/AVFoundationSoftLink.h:
  • pal/cocoa/AVFoundationSoftLink.mm:
Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r268307 r268308  
     12020-10-09  Jer Noble  <jer.noble@apple.com>
     2
     3        [Mac] AirPlay menu does not show up when AirPlay button is clicked
     4        https://bugs.webkit.org/show_bug.cgi?id=217536
     5        <rdar://problem/69973777>
     6
     7        Reviewed by Eric Carlson.
     8
     9        PAL tries to soft-link the AVRoutePickerView from the AVFoundation framework, rather than the (correct)
     10        AVKit framework. Remove AVRoutePickerView from AVFoundationSoftLink.h and use the already declared version
     11        inside AVRoutePickerViewTargetPicker.mm.
     12
     13        * platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm:
     14        (WebCore::AVRoutePickerViewTargetPicker::isAvailable):
     15
    1162020-10-09  Zalan Bujtas  <zalan@apple.com>
    217
  • trunk/Source/WebCore/PAL/ChangeLog

    r267870 r268308  
     12020-10-09  Jer Noble  <jer.noble@apple.com>
     2
     3        [Mac] AirPlay menu does not show up when AirPlay button is clicked
     4        https://bugs.webkit.org/show_bug.cgi?id=217536
     5        <rdar://problem/69973777>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * pal/cocoa/AVFoundationSoftLink.h:
     10        * pal/cocoa/AVFoundationSoftLink.mm:
     11
    1122020-10-02  Youenn Fablet  <youenn@apple.com>
    213
  • trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h

    r264710 r268308  
    8181#if HAVE(AVAUDIO_ROUTING_ARBITER)
    8282SOFT_LINK_CLASS_FOR_HEADER(PAL, AVAudioRoutingArbiter)
    83 #endif
    84 
    85 #if HAVE(AVROUTEPICKERVIEW)
    86 SOFT_LINK_CLASS_FOR_HEADER(PAL, AVRoutePickerView)
    8783#endif
    8884
  • trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm

    r264710 r268308  
    112112SOFT_LINK_CLASS_FOR_SOURCE_WITH_EXPORT(PAL, AVFoundation, AVRouteDetector, PAL_EXPORT)
    113113SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL_WITH_EXPORT(PAL, AVFoundation, AVVideoPerformanceMetrics, PAL_EXPORT)
    114 #endif
    115 
    116 #if HAVE(AVROUTEPICKERVIEW)
    117 SOFT_LINK_CLASS_FOR_SOURCE_OPTIONAL_WITH_EXPORT(PAL, AVFoundation, AVRoutePickerView, PAL_EXPORT)
    118114#endif
    119115
  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/AVRoutePickerViewTargetPicker.mm

    r264663 r268308  
    6161    static std::once_flag flag;
    6262    std::call_once(flag, [] () {
    63         if (!PAL::getAVRoutePickerViewClass())
     63        if (!getAVRoutePickerViewClass())
    6464            return;
    6565
Note: See TracChangeset for help on using the changeset viewer.