Changeset 268472 in webkit

Timestamp:

Oct 14, 2020 10:44:54 AM (4 years ago)

Author:

svillar@igalia.com

Message:

[GLIB] Fix linking error for systems not providing <sys/memfd.h>
​https://bugs.webkit.org/show_bug.cgi?id=217514

Reviewed by Carlos Garcia Campos.

• UIProcess/Launcher/glib/BubblewrapLauncher.cpp: Unconditionally check for <sys/mman.h> which should always exist instead

of <sys/memfd.h>. Also define the fallback with syscall() only for linux systems (as it requires <linux/memfd.h>).

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Launcher/glib/BubblewrapLauncher.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-10-14  Sergio Villar Senin  <svillar@igalia.com>
+
+        [GLIB] Fix linking error for systems not providing <sys/memfd.h>
+        https://bugs.webkit.org/show_bug.cgi?id=217514
+
+        Reviewed by Carlos Garcia Campos.
+
+        * UIProcess/Launcher/glib/BubblewrapLauncher.cpp: Unconditionally check for <sys/mman.h> which should always exist instead
+        of <sys/memfd.h>. Also define the fallback with syscall() only for linux systems (as it requires <linux/memfd.h>).
+
 2020-10-14  Kate Cheney  <katherine_cheney@apple.com>
 

trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp

@@ -41 +41 @@
 #endif
 
-#if __has_include(<sys/memfd.h>)
-
-#include <sys/memfd.h>
-
-#else
+#include <sys/mman.h>
+
+#ifndef MFD_ALLOW_SEALING
+
+#if HAVE(LINUX_MEMFD_H)
+
+#include <linux/memfd.h>
 
 // These defines were added in glibc 2.27, the same release that added memfd_create.
@@ -60 +62 @@
 #define F_SEAL_WRITE  0x0008
 
-#define MFD_ALLOW_SEALING 2U
-
 static int memfd_create(const char* name, unsigned flags)
 {
     return syscall(__NR_memfd_create, name, flags);
 }
-#endif
+#endif // #if HAVE(LINUX_MEMFD_H)
+
+#endif // #ifndef MFD_ALLOW_SEALING
 
 namespace WebKit {