Changeset 268553 in webkit

Timestamp:

Oct 15, 2020 2:15:18 PM (4 years ago)

Author:

Chris Dumez

Message:

Use std::fill_n() instead of for loops in AudioParam::calculateFinalValues()
​https://bugs.webkit.org/show_bug.cgi?id=217766

Reviewed by Geoffrey Garen.

Use std::fill_n() instead of for loops in AudioParam::calculateFinalValues().

No new tests, no Web-facing behavior change.

• Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateFinalValues):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webaudio/AudioParam.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-10-15  Chris Dumez  <cdumez@apple.com>
+
+        Use std::fill_n() instead of for loops in AudioParam::calculateFinalValues()
+        https://bugs.webkit.org/show_bug.cgi?id=217766
+
+        Reviewed by Geoffrey Garen.
+
+        Use std::fill_n() instead of for loops in AudioParam::calculateFinalValues().
+
+        No new tests, no Web-facing behavior change.
+
+        * Modules/webaudio/AudioParam.cpp:
+        (WebCore::AudioParam::calculateFinalValues):
+
 2020-10-15  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/Modules/webaudio/AudioParam.cpp

@@ -267 +267 @@
         if (timelineValue)
             m_value = *timelineValue;
-
-        for (unsigned i = 0; i < numberOfValues; ++i)
-            values[i] = m_value;
+        std::fill_n(values, numberOfValues, m_value);
     }
 
@@ -295 +293 @@
 
     // If we're not sample accurate, duplicate the first element of |values| to all of the elements.
-    if (!sampleAccurate) {
-        for (unsigned i = 1; i < numberOfValues; ++i)
-            values[i] = values[0];
-    }
+    if (!sampleAccurate)
+        std::fill_n(values + 1, numberOfValues - 1, values[0]);
 
     // Clamp values based on range allowed by AudioParam's min and max values.