Changeset 268562 in webkit

Timestamp:

Oct 15, 2020 5:06:17 PM (4 years ago)

Author:

ddkilzer@apple.com

Message:

PDFPlugin.mm:2303:139: error: type 'SEL _Nullable' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing]
<​https://webkit.org/b/217791>
<rdar://problem/70349804>

Reviewed by Tim Horton.

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::handleContextMenuEvent):

• Use !! to convert result to bool.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/Plugins/PDF/PDFPlugin.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-10-15  David Kilzer  <ddkilzer@apple.com>
+
+        PDFPlugin.mm:2303:139: error: type 'SEL _Nullable' cannot be narrowed to 'bool' in initializer list [-Wc++11-narrowing]
+        <https://webkit.org/b/217791>
+        <rdar://problem/70349804>
+
+        Reviewed by Tim Horton.
+
+        * WebProcess/Plugins/PDF/PDFPlugin.mm:
+        (WebKit::PDFPlugin::handleContextMenuEvent):
+        - Use `!!` to convert result to `bool`.
+
 2020-10-15  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm

@@ -2301 +2301 @@
         if ([item submenu])
             continue;
-        PDFContextMenuItem menuItem { String([item title]), !![item isEnabled], !![item isSeparatorItem], static_cast<int>([item state]), [item action], i };
+        PDFContextMenuItem menuItem { String([item title]), !![item isEnabled], !![item isSeparatorItem], static_cast<int>([item state]), !![item action], i };
         items.append(WTFMove(menuItem));
     }