Changeset 268569 in webkit

Timestamp:

Oct 15, 2020 6:39:03 PM (4 years ago)

Author:

timothy_horton@apple.com

Message:

iPhone apps and iPad apps linked before iOS 13 running on macOS get desktop UA unexpectedly
​https://bugs.webkit.org/show_bug.cgi?id=217798
<rdar://problem/70254509>

Reviewed by Wenson Hsieh.

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingRecommended):
Share more of the code with iOS, for compatibility and consistency's sake:
iOS apps running on macOS should use the mobile UA if they are iPhone-only,
or if they were linked on an SDK earlier than iOS 13. This matches their
behavior on iPad.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WebPageProxyIOS.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-10-15  Tim Horton  <timothy_horton@apple.com>
+
+        iPhone apps and iPad apps linked before iOS 13 running on macOS get desktop UA unexpectedly
+        https://bugs.webkit.org/show_bug.cgi?id=217798
+        <rdar://problem/70254509>
+
+        Reviewed by Wenson Hsieh.
+
+        * UIProcess/ios/WebPageProxyIOS.mm:
+        (WebKit::desktopClassBrowsingRecommended):
+        Share more of the code with iOS, for compatibility and consistency's sake:
+        iOS apps running on macOS should use the mobile UA if they are iPhone-only,
+        or if they were linked on an SDK earlier than iOS 13. This matches their
+        behavior on iPad.
+
 2020-10-15  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

@@ -1449 +1449 @@
     dispatch_once(&onceToken, ^{
 #if PLATFORM(MACCATALYST)
-        UNUSED_PARAM(ignoreSafeguards);
-        shouldRecommendDesktopClassBrowsing = true;
+        shouldRecommendDesktopClassBrowsing = desktopClassBrowsingSupported();
 #else
         // While desktop-class browsing is supported on all iPad models, it is not recommended for iPad mini.
         auto screenClass = MGGetSInt32Answer(kMGQMainScreenClass, MGScreenClassPad2);
         shouldRecommendDesktopClassBrowsing = screenClass != MGScreenClassPad3 && screenClass != MGScreenClassPad4 && desktopClassBrowsingSupported();
+#endif
         if (ignoreSafeguards == IgnoreAppCompatibilitySafeguards::No && !linkedOnOrAfter(WebCore::SDKVersion::FirstWithModernCompabilityModeByDefault)) {
             // Opt out apps that haven't yet built against the iOS 13 SDK to limit any incompatibilities as a result of enabling desktop-class browsing by default in
@@ -1460 +1460 @@
             shouldRecommendDesktopClassBrowsing = false;
         }
-#endif
     });
     return shouldRecommendDesktopClassBrowsing;