Changeset 268602 in webkit
- Timestamp:
- Oct 16, 2020 12:20:41 PM (4 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r268600 r268602 1 2020-10-16 Jiewen Tan <jiewen_tan@apple.com> 2 3 [WebAuthn] Remove the "alg" field in the attestation statement 4 https://bugs.webkit.org/show_bug.cgi?id=217720 5 <rdar://problem/70349734> 6 7 Reviewed by Brent Fulgham. 8 9 * http/wpt/webauthn/public-key-credential-create-success-local.https.html: 10 1 11 2020-10-16 Chris Dumez <cdumez@apple.com> 2 12 -
trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-local.https.html
r259680 r268602 39 39 assert_object_equals(attestationObject.attStmt, { }); 40 40 else { 41 assert_equals(attestationObject.attStmt.alg, -7);42 41 assert_equals(attestationObject.attStmt.x5c.length, 2); 43 42 assert_array_equals(attestationObject.attStmt.x5c[0], Base64URL.parse(testAttestationCertificateBase64)); -
trunk/Source/WebKit/ChangeLog
r268577 r268602 1 2020-10-16 Jiewen Tan <jiewen_tan@apple.com> 2 3 [WebAuthn] Remove the "alg" field in the attestation statement 4 https://bugs.webkit.org/show_bug.cgi?id=217720 5 <rdar://problem/70349734> 6 7 Reviewed by Brent Fulgham. 8 9 This old field was used in an unreleased old attestation statement format and is not used by 10 the final attestation statement format that will be added to the spec: 11 https://github.com/w3c/webauthn/pull/1491. 12 13 Therefore, remove it to resolve confusion. 14 15 Covered by existing tests. 16 17 * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm: 18 (WebKit::LocalAuthenticator::continueMakeCredentialAfterAttested): 19 1 20 2020-10-16 Youenn Fablet <youenn@apple.com> 2 21 -
trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm
r263782 r268602 403 403 cbor::CBORValue::MapValue attestationStatementMap; 404 404 { 405 attestationStatementMap[cbor::CBORValue("alg")] = cbor::CBORValue(COSE::ES256);406 405 Vector<cbor::CBORValue> cborArray; 407 406 for (size_t i = 0; i < [certificates count]; i++)
Note: See TracChangeset
for help on using the changeset viewer.