Changeset 268629 in webkit


Ignore:
Timestamp:
Oct 16, 2020 9:07:22 PM (4 years ago)
Author:
Devin Rousso
Message:

Web Inspector: REGRESSION(r266074): line-based JavaScript breakpoints don't hit after reload
​https://bugs.webkit.org/show_bug.cgi?id=217862

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::clearDebuggerBreakpointState):
Don't clear the list of protocol breakpoints when the global object changes. Protocol
breakpoints should only be cleared when individually removed or by Debugger.disable.

LayoutTests:

  • inspector/debugger/resources/nested-calls.js: Added.

(inner):
(outer):

  • inspector/debugger/breakpoint-resolve-when-script-added.html: Added.
  • inspector/debugger/breakpoint-resolve-when-script-added-expected.txt: Added.
Location:
trunk
Files:
3 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r268627 r268629  
     12020-10-16  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: REGRESSION(r266074): line-based JavaScript breakpoints don't hit after reload
     4        https://bugs.webkit.org/show_bug.cgi?id=217862
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        * inspector/debugger/resources/nested-calls.js: Added.
     9        (inner):
     10        (outer):
     11
     12        * inspector/debugger/breakpoint-resolve-when-script-added.html: Added.
     13        * inspector/debugger/breakpoint-resolve-when-script-added-expected.txt: Added.
     14
    1152020-10-16  Dean Jackson  <dino@apple.com>
    216

  • trunk/Source/JavaScriptCore/ChangeLog

    r268593 r268629  
     12020-10-16  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: REGRESSION(r266074): line-based JavaScript breakpoints don't hit after reload
     4        https://bugs.webkit.org/show_bug.cgi?id=217862
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        * inspector/agents/InspectorDebuggerAgent.cpp:
     9        (Inspector::InspectorDebuggerAgent::clearDebuggerBreakpointState):
     10        Don't clear the list of protocol breakpoints when the global object changes. Protocol
     11        breakpoints should only be cleared when individually removed or by `Debugger.disable`.
     12
    1132020-10-16  Saam Barati  <sbarati@apple.com>
    214

  • trunk/Source/JavaScriptCore/inspector/agents/InspectorDebuggerAgent.cpp

    r266885 r268629  
    13381338    m_currentCallStack = { };
    13391339    m_scripts.clear();
    1340     m_protocolBreakpointForProtocolBreakpointID.clear();
    13411340    m_debuggerBreakpointsForProtocolBreakpointID.clear();
    13421341    m_nextDebuggerBreakpointID = JSC::noBreakpointID + 1;
Note: See TracChangeset for help on using the changeset viewer.