Changeset 268636 in webkit


Ignore:
Timestamp:
Oct 16, 2020 9:55:32 PM (3 years ago)
Author:
Wenson Hsieh
Message:

Add system trace points for flushing remote image buffers
https://bugs.webkit.org/show_bug.cgi?id=217853

Reviewed by Simon Fraser.

Source/WebKit:

Add trace points to capture drawing context flushes. This encapsulates time spent encoding display lists in
preparation for IPC.

  • WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp:

(WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContext):
(WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContextAndWaitCommit):

Source/WTF:

See WebKit ChangeLog for more details.

  • wtf/SystemTracing.h:

Tools:

See WebKit ChangeLog for more details.

  • Tracing/SystemTracePoints.plist:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WTF/ChangeLog

    r268628 r268636  
     12020-10-16  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Add system trace points for flushing remote image buffers
     4        https://bugs.webkit.org/show_bug.cgi?id=217853
     5
     6        Reviewed by Simon Fraser.
     7
     8        See WebKit ChangeLog for more details.
     9
     10        * wtf/SystemTracing.h:
     11
    1122020-10-16  Jiewen Tan  <jiewen_tan@apple.com>
    213
  • trunk/Source/WTF/wtf/SystemTracing.h

    r261985 r268636  
    115115    LayerTreeFreezeStart,
    116116    LayerTreeFreezeEnd,
     117    FlushRemoteImageBufferStart,
     118    FlushRemoteImageBufferEnd,
    117119
    118120    UIProcessRange = 14000,
  • trunk/Source/WebKit/ChangeLog

    r268635 r268636  
     12020-10-16  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Add system trace points for flushing remote image buffers
     4        https://bugs.webkit.org/show_bug.cgi?id=217853
     5
     6        Reviewed by Simon Fraser.
     7
     8        Add trace points to capture drawing context flushes. This encapsulates time spent encoding display lists in
     9        preparation for IPC.
     10
     11        * WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp:
     12        (WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContext):
     13        (WebKit::RemoteImageBufferMessageHandlerProxy::flushDrawingContextAndWaitCommit):
     14
    1152020-10-16  Devin Rousso  <drousso@apple.com>
    216
  • trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandlerProxy.cpp

    r268612 r268636  
    3333#include "RemoteRenderingBackendProxy.h"
    3434#include <WebCore/DisplayListItems.h>
     35#include <wtf/SystemTracing.h>
    3536
    3637namespace WebKit {
     
    7677        return;
    7778   
     79    TraceScope tracingScope(FlushRemoteImageBufferStart, FlushRemoteImageBufferEnd);
    7880    m_remoteRenderingBackendProxy->send(Messages::RemoteRenderingBackend::FlushImageBufferDrawingContext(displayList, m_remoteResourceIdentifier), m_remoteRenderingBackendProxy->renderingBackendIdentifier());
    7981    displayList.clear();
     
    8486    if (!m_remoteRenderingBackendProxy)
    8587        return;
     88
     89    TraceScope tracingScope(FlushRemoteImageBufferStart, FlushRemoteImageBufferEnd, 1);
    8690    m_sentFlushIdentifier = ImageBufferFlushIdentifier::generate();
    8791    m_remoteRenderingBackendProxy->send(Messages::RemoteRenderingBackend::FlushImageBufferDrawingContextAndCommit(displayList, m_sentFlushIdentifier, m_remoteResourceIdentifier), m_remoteRenderingBackendProxy->renderingBackendIdentifier());
  • trunk/Tools/ChangeLog

    r268633 r268636  
     12020-10-16  Wenson Hsieh  <wenson_hsieh@apple.com>
     2
     3        Add system trace points for flushing remote image buffers
     4        https://bugs.webkit.org/show_bug.cgi?id=217853
     5
     6        Reviewed by Simon Fraser.
     7
     8        See WebKit ChangeLog for more details.
     9
     10        * Tracing/SystemTracePoints.plist:
     11
    1122020-10-16  Ryosuke Niwa  <rniwa@webkit.org>
    213
  • trunk/Tools/Tracing/SystemTracePoints.plist

    r261985 r268636  
    460460             <dict>
    461461                 <key>Name</key>
     462                 <string>Flush remote image buffer</string>
     463                 <key>Type</key>
     464                 <string>Interval</string>
     465                 <key>Component</key>
     466                 <string>47</string>
     467                 <key>CodeBegin</key>
     468                 <string>12015</string>
     469                 <key>CodeEnd</key>
     470                 <string>12016</string>
     471             </dict>
     472             <dict>
     473                 <key>Name</key>
    462474                 <string>Commit RemoteLayerTree transaction</string>
    463475                 <key>Type</key>
Note: See TracChangeset for help on using the changeset viewer.