Changeset 26924 in webkit

Timestamp:

Oct 23, 2007 12:29:03 PM (17 years ago)

Author:

alp

Message:

2007-10-23 Jasper Bryant-Greene <​m@ni.ac.nz>

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=15058
Precedence fault in KeyEventGdk causes shift, control, alt etc to work incorrectly

Corrected precendence fault which was causing Shift, Alt, Control and
Meta to behave incorrectly on GTK.

Coding style fix by Alp.

• platform/gtk/KeyEventGtk.cpp: (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/KeyEventGtk.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-10-23  Jasper Bryant-Greene  <m@ni.ac.nz>
+
+        Reviewed by Darin.
+
+        http://bugs.webkit.org/show_bug.cgi?id=15058
+        Precedence fault in KeyEventGdk causes shift, control, alt etc to work incorrectly
+
+        Corrected precendence fault which was causing Shift, Alt, Control and
+        Meta to behave incorrectly on GTK.
+
+        Coding style fix by Alp.
+
+        * platform/gtk/KeyEventGtk.cpp:
+        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+
 2007-10-23  Sam Weinig  <sam@webkit.org>
 

trunk/WebCore/platform/gtk/KeyEventGtk.cpp

@@ -476 +476 @@
     , m_WindowsKeyCode(windowsKeyCodeForKeyEvent(event->keyval))
     , m_isKeypad(false)
-    , m_shiftKey(event->state & GDK_SHIFT_MASK != 0)
-    , m_ctrlKey(event->state & GDK_CONTROL_MASK != 0)
-    , m_altKey(event->state & GDK_MOD1_MASK != 0)
-    , m_metaKey(event->state & GDK_MOD2_MASK != 0)
+    , m_shiftKey(event->state & GDK_SHIFT_MASK)
+    , m_ctrlKey(event->state & GDK_CONTROL_MASK)
+    , m_altKey(event->state & GDK_MOD1_MASK)
+    , m_metaKey(event->state & GDK_MOD2_MASK)
 {
 }