Changeset 269335 in webkit

Timestamp:

Nov 3, 2020 3:05:29 PM (3 years ago)

Author:

Jonathan Bedard

Message:

[webkitscmpy] Populate parent branch for tags
<rdar://problem/70998928>
​https://bugs.webkit.org/show_bug.cgi?id=218521

Rubber-stamped by Aakash Jain.

• Scripts/libraries/webkitscmpy/webkitscmpy/init.py: Version bump.
• Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:

(Svn.commit): Populate cache of commits when the canonical branch does not match
the provided commit.

• Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:

(TestSvn):
(TestSvn.test_tag_previous):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (modified) (1 diff)
• Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py (modified) (1 diff)
• Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-11-03  Jonathan Bedard  <jbedard@apple.com>
+
+        [webkitscmpy] Populate parent branch for tags
+        <rdar://problem/70998928>
+        https://bugs.webkit.org/show_bug.cgi?id=218521
+
+        Rubber-stamped by Aakash Jain.
+
+        * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Version bump.
+        * Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
+        (Svn.commit): Populate cache of commits when the canonical branch does not match
+        the provided commit.
+        * Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:
+        (TestSvn):
+        (TestSvn.test_tag_previous):
+
 2020-11-03  David Kilzer  <ddkilzer@apple.com>
 

trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py

@@ -47 +47 @@
     )
 
-version = Version(0, 2, 6)
+version = Version(0, 2, 7)
 
 AutoInstall.register(Package('dateutil', Version(2, 8, 1), pypi_name='python-dateutil'))

trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py

@@ -301 +301 @@
             info = self.info(cached=True, branch=branch, revision=revision)
             branch = self._branch_for(revision)
+            if not self._metadata_cache.get(branch, []) or identifier >= len(self._metadata_cache.get(branch, [])):
+                self._cache_revisions(branch=branch)
 
         elif revision:

trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py

@@ -201 +201 @@
         with mocks.local.Svn(self.path), OutputCapture():
             self.assertEqual(9, local.Svn(self.path).commit(tag='tag-1').revision)
+
+    def test_tag_previous(self):
+        with mocks.local.Svn(self.path), OutputCapture():
+            self.assertEqual(7, local.Svn(self.path).commit(identifier='2.2@tags/tag-1').revision)