Changeset 269366 in webkit

Timestamp:

Nov 4, 2020 9:40:10 AM (3 years ago)

Author:

graouts@webkit.org

Message:

[ macOS ] webanimations/accelerated-animation-easing-update-after-pause.html is a flaky ImageOnlyFailure
​https://bugs.webkit.org/show_bug.cgi?id=216481
<rdar://problem/68858100>

Reviewed by Dean Jackson.

Improve this test's fidelity by making the animation much longer (1 day) and ensuring we always wait one presentation
and one rendering update before committing any changes to the animations.

• platform/mac/TestExpectations:
• webanimations/accelerated-animation-easing-update-after-pause.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)
• webanimations/accelerated-animation-easing-update-after-pause.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-11-04  Antoine Quint  <graouts@webkit.org>
+
+        [ macOS ] webanimations/accelerated-animation-easing-update-after-pause.html is a flaky ImageOnlyFailure
+        https://bugs.webkit.org/show_bug.cgi?id=216481
+        <rdar://problem/68858100>
+
+        Reviewed by Dean Jackson.
+
+        Improve this test's fidelity by making the animation much longer (1 day) and ensuring we always wait one presentation
+        and one rendering update before committing any changes to the animations.
+
+        * platform/mac/TestExpectations:
+        * webanimations/accelerated-animation-easing-update-after-pause.html:
+
 2020-11-04  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -2198 +2198 @@
 [ BigSur+ ] fast/images/animated-gif-loop-count.html [ ImageOnlyFailure ]
 
-webkit.org/b/216481 webanimations/accelerated-animation-easing-update-after-pause.html [ Pass ImageOnlyFailure ]
-
 webkit.org/b/216492 imported/w3c/web-platform-tests/selection/extend-20.html [ Slow ]
 webkit.org/b/216492 imported/w3c/web-platform-tests/selection/extend-00.html [ Slow ]

trunk/LayoutTests/webanimations/accelerated-animation-easing-update-after-pause.html

@@ -37 +37 @@
     const keyframes = { "transform": "translateX(700px)" };
     const easing = "cubic-bezier(0,1,0,1)";
-    const duration = 10000;
+    const duration = 24 * 60 * 60 * 1000;
 
     // Create two animations, a test which will change easing during playback and a reference which
@@ -56 +56 @@
 
     // Wait a frame and resume the animations.
+    await UIHelper.ensurePresentationUpdate();
     await UIHelper.renderingUpdate();
     for (let animation of document.getAnimations())