Context Navigation

← Previous Changeset
Next Changeset →

Changeset 269436 in webkit

Timestamp:

Nov 5, 2020 8:56:12 AM (3 years ago)

Author:

youenn@apple.com

Message:

Consider blocking ports 5060 and 5061
https://bugs.webkit.org/show_bug.cgi?id=218557
<rdar://problem/71031479>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

web-platform-tests/fetch/api/request/request-bad-port.any-expected.txt: Added.
web-platform-tests/fetch/api/request/request-bad-port.any.html: Added.
web-platform-tests/fetch/api/request/request-bad-port.any.js: Added.

(BLOCKED_PORTS_LIST.map):

web-platform-tests/fetch/api/request/request-bad-port.any.worker-expected.txt: Added.
web-platform-tests/fetch/api/request/request-bad-port.any.worker.html: Added.
web-platform-tests/fetch/api/request/request-bad-port.html: Removed.
web-platform-tests/tools/wptserve/wptserve/utils.py:

(is_bad_port):

web-platform-tests/websockets/Create-blocked-port.any-expected.txt:
web-platform-tests/websockets/Create-blocked-port.any.js:
web-platform-tests/websockets/Create-blocked-port.any.worker-expected.txt:

Source/WTF:

wtf/URL.cpp:

(WTF::portAllowed):

LayoutTests:

TestExpectations:

Location:

trunk

Files:

: 3 added
: 1 deleted
: 9 edited
: 1 copied
: 1 moved

LayoutTests/ChangeLog (modified) (1 diff)
LayoutTests/TestExpectations (modified) (1 diff)
LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.any-expected.txt (moved) (moved from trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port-expected.txt) (2 diffs)
LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.any.html (added)
LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.any.js (added)
LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.any.worker-expected.txt (copied) (copied from trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port-expected.txt) (2 diffs)
LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.any.worker.html (added)
LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.html (deleted)
LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/utils.py (modified) (1 diff)
LayoutTests/imported/w3c/web-platform-tests/websockets/Create-blocked-port.any-expected.txt (modified) (2 diffs)
LayoutTests/imported/w3c/web-platform-tests/websockets/Create-blocked-port.any.js (modified) (1 diff)
LayoutTests/imported/w3c/web-platform-tests/websockets/Create-blocked-port.any.worker-expected.txt (modified) (1 diff)
Source/WTF/ChangeLog (modified) (1 diff)
Source/WTF/wtf/URL.cpp (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/LayoutTests/ChangeLog

-                      r269426
+                      r269436
+-11-05  Youenn Fablet  <youenn@apple.com>
+        Consider blocking ports 5060 and 5061
+        https://bugs.webkit.org/show_bug.cgi?id=218557
+        <rdar://problem/71031479>
+        Reviewed by Alex Christensen.
+        * TestExpectations:
 -11-05  Ziran Sun  <zsun@igalia.com>

trunk/LayoutTests/TestExpectations

r269407	r269436
3057	3057
3058	3058	# Timing out WebSocket tests.
3059		~~imported/w3c/web-platform-tests/websockets/Create-blocked-port.any.worker.html [ Skip ]~~
3060		~~imported/w3c/web-platform-tests/websockets/Create-blocked-port.any.html [ Skip ]~~
3061	3059	imported/w3c/web-platform-tests/websockets/binaryType-wrong-value.any.html [ Skip ]
3062	3060	imported/w3c/web-platform-tests/websockets/binaryType-wrong-value.any.worker.html [ Skip ]

trunk/LayoutTests/imported/w3c/ChangeLog

-                      r269426
+                      r269436
+-11-05  Youenn Fablet  <youenn@apple.com>
+        Consider blocking ports 5060 and 5061
+        https://bugs.webkit.org/show_bug.cgi?id=218557
+        <rdar://problem/71031479>
+        Reviewed by Alex Christensen.
+        * web-platform-tests/fetch/api/request/request-bad-port.any-expected.txt: Added.
+        * web-platform-tests/fetch/api/request/request-bad-port.any.html: Added.
+        * web-platform-tests/fetch/api/request/request-bad-port.any.js: Added.
+        (BLOCKED_PORTS_LIST.map):
+        * web-platform-tests/fetch/api/request/request-bad-port.any.worker-expected.txt: Added.
+        * web-platform-tests/fetch/api/request/request-bad-port.any.worker.html: Added.
+        * web-platform-tests/fetch/api/request/request-bad-port.html: Removed.
+        * web-platform-tests/tools/wptserve/wptserve/utils.py:
+        (is_bad_port):
+        * web-platform-tests/websockets/Create-blocked-port.any-expected.txt:
+        * web-platform-tests/websockets/Create-blocked-port.any.js:
+        * web-platform-tests/websockets/Create-blocked-port.any.worker-expected.txt:
 -11-05  Ziran Sun  <zsun@igalia.com>

trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.any-expected.txt

-                      r269435
+                      r269436
 Blocked access to external URL http://example.com:3659/
 Blocked access to external URL http://example.com:4045/
+Blocked access to external URL http://example.com:5060/
+Blocked access to external URL http://example.com:5061/
 Blocked access to external URL http://example.com:6000/
 Blocked access to external URL http://example.com:6665/
 …
 PASS Request on bad port 3659 should throw TypeError.
 PASS Request on bad port 4045 should throw TypeError.
+PASS Request on bad port 5060 should throw TypeError.
+PASS Request on bad port 5061 should throw TypeError.
 PASS Request on bad port 6000 should throw TypeError.
 PASS Request on bad port 6665 should throw TypeError.

trunk/LayoutTests/imported/w3c/web-platform-tests/fetch/api/request/request-bad-port.any.worker-expected.txt

-                      r269435
+                      r269436
 Blocked access to external URL http://example.com:3659/
 Blocked access to external URL http://example.com:4045/
+Blocked access to external URL http://example.com:5060/
+Blocked access to external URL http://example.com:5061/
 Blocked access to external URL http://example.com:6000/
 Blocked access to external URL http://example.com:6665/
 …
 PASS Request on bad port 3659 should throw TypeError.
 PASS Request on bad port 4045 should throw TypeError.
+PASS Request on bad port 5060 should throw TypeError.
+PASS Request on bad port 5061 should throw TypeError.
 PASS Request on bad port 6000 should throw TypeError.
 PASS Request on bad port 6665 should throw TypeError.

trunk/LayoutTests/imported/w3c/web-platform-tests/tools/wptserve/wptserve/utils.py

r269235	r269436
131	131	3659, # apple-sasl
132	132	4045, # lockd
	133	5060, # sip
	134	5061, # sips
133	135	6000, # x11
134	136	6665, # irc (alternate)

trunk/LayoutTests/imported/w3c/web-platform-tests/websockets/Create-blocked-port.any-expected.txt

-                      r267649
+                      r269436
-CONSOLE MESSAGE: WebSocket port 1 blocked
-CONSOLE MESSAGE: WebSocket port 7 blocked
-CONSOLE MESSAGE: WebSocket port 9 blocked
-CONSOLE MESSAGE: WebSocket port 11 blocked
-CONSOLE MESSAGE: WebSocket port 13 blocked
-CONSOLE MESSAGE: WebSocket port 15 blocked
-CONSOLE MESSAGE: WebSocket port 17 blocked
-CONSOLE MESSAGE: WebSocket port 19 blocked
-CONSOLE MESSAGE: WebSocket port 20 blocked
-CONSOLE MESSAGE: WebSocket port 21 blocked
-CONSOLE MESSAGE: WebSocket port 22 blocked
-CONSOLE MESSAGE: WebSocket port 23 blocked
-CONSOLE MESSAGE: WebSocket port 25 blocked
-CONSOLE MESSAGE: WebSocket port 37 blocked
-CONSOLE MESSAGE: WebSocket port 42 blocked
-CONSOLE MESSAGE: WebSocket port 43 blocked
-CONSOLE MESSAGE: WebSocket port 53 blocked
-CONSOLE MESSAGE: WebSocket port 77 blocked
-CONSOLE MESSAGE: WebSocket port 79 blocked
-CONSOLE MESSAGE: WebSocket port 87 blocked
-CONSOLE MESSAGE: WebSocket port 95 blocked
-CONSOLE MESSAGE: WebSocket port 101 blocked
-CONSOLE MESSAGE: WebSocket port 102 blocked
-CONSOLE MESSAGE: WebSocket port 103 blocked
-CONSOLE MESSAGE: WebSocket port 104 blocked
-CONSOLE MESSAGE: WebSocket port 109 blocked
-CONSOLE MESSAGE: WebSocket port 110 blocked
-CONSOLE MESSAGE: WebSocket port 111 blocked
-CONSOLE MESSAGE: WebSocket port 113 blocked
-CONSOLE MESSAGE: WebSocket port 115 blocked
-CONSOLE MESSAGE: WebSocket port 117 blocked
-CONSOLE MESSAGE: WebSocket port 119 blocked
-CONSOLE MESSAGE: WebSocket port 123 blocked
-CONSOLE MESSAGE: WebSocket port 135 blocked
-CONSOLE MESSAGE: WebSocket port 139 blocked
-CONSOLE MESSAGE: WebSocket port 143 blocked
-CONSOLE MESSAGE: WebSocket port 179 blocked
-CONSOLE MESSAGE: WebSocket port 389 blocked
-CONSOLE MESSAGE: WebSocket port 427 blocked
-CONSOLE MESSAGE: WebSocket port 465 blocked
-CONSOLE MESSAGE: WebSocket port 512 blocked
-CONSOLE MESSAGE: WebSocket port 513 blocked
-CONSOLE MESSAGE: WebSocket port 514 blocked
-CONSOLE MESSAGE: WebSocket port 515 blocked
-CONSOLE MESSAGE: WebSocket port 526 blocked
-CONSOLE MESSAGE: WebSocket port 530 blocked
-CONSOLE MESSAGE: WebSocket port 531 blocked
-CONSOLE MESSAGE: WebSocket port 532 blocked
-CONSOLE MESSAGE: WebSocket port 540 blocked
-CONSOLE MESSAGE: WebSocket port 548 blocked
-CONSOLE MESSAGE: WebSocket port 556 blocked
-CONSOLE MESSAGE: WebSocket port 563 blocked
-CONSOLE MESSAGE: WebSocket port 587 blocked
-CONSOLE MESSAGE: WebSocket port 601 blocked
-CONSOLE MESSAGE: WebSocket port 636 blocked
-CONSOLE MESSAGE: WebSocket port 993 blocked
-CONSOLE MESSAGE: WebSocket port 995 blocked
-CONSOLE MESSAGE: WebSocket port 2049 blocked
-CONSOLE MESSAGE: WebSocket port 3659 blocked
-CONSOLE MESSAGE: WebSocket port 4045 blocked
-CONSOLE MESSAGE: WebSocket port 6000 blocked
-CONSOLE MESSAGE: WebSocket port 6665 blocked
-CONSOLE MESSAGE: WebSocket port 6666 blocked
-CONSOLE MESSAGE: WebSocket port 6667 blocked
-CONSOLE MESSAGE: WebSocket port 6668 blocked
-CONSOLE MESSAGE: WebSocket port 6669 blocked
-CONSOLE MESSAGE: WebSocket port 6697 blocked
 PASS Basic check
 …
 FAIL WebSocket blocked port test 3659 The operation is insecure.
 FAIL WebSocket blocked port test 4045 The operation is insecure.
+FAIL WebSocket blocked port test 5060 The operation is insecure.
+FAIL WebSocket blocked port test 5061 The operation is insecure.
 FAIL WebSocket blocked port test 6000 The operation is insecure.
 FAIL WebSocket blocked port test 6665 The operation is insecure.

trunk/LayoutTests/imported/w3c/web-platform-tests/websockets/Create-blocked-port.any.js

r246406	r269436
69	69	3659, // apple-sasl
70	70	4045, // lockd
	71	5060, // sip
	72	5061, // sips
71	73	6000, // x11
72	74	6665, // irc (alternate)

trunk/LayoutTests/imported/w3c/web-platform-tests/websockets/Create-blocked-port.any.worker-expected.txt

r267649	r269436
61	61	FAIL WebSocket blocked port test 3659 The operation is insecure.
62	62	FAIL WebSocket blocked port test 4045 The operation is insecure.
	63	FAIL WebSocket blocked port test 5060 The operation is insecure.
	64	FAIL WebSocket blocked port test 5061 The operation is insecure.
63	65	FAIL WebSocket blocked port test 6000 The operation is insecure.
64	66	FAIL WebSocket blocked port test 6665 The operation is insecure.

trunk/Source/WTF/ChangeLog

-                      r269416
+                      r269436
+-11-05  Youenn Fablet  <youenn@apple.com>
+        Consider blocking ports 5060 and 5061
+        https://bugs.webkit.org/show_bug.cgi?id=218557
+        <rdar://problem/71031479>
+        Reviewed by Alex Christensen.
+        * wtf/URL.cpp:
+        (WTF::portAllowed):
 -11-04  Said Abou-Hallawa  <said@apple.com>

trunk/Source/WTF/wtf/URL.cpp

r268853	r269436
954	954	4045, // lockd
955	955	4190, // ManageSieve [Apple addition]
	956	5060, // SIP
	957	5061, // SIPS
956	958	6000, // X11
957	959	6665, // Alternate IRC [Apple addition]

Note: See TracChangeset for help on using the changeset viewer.

Context Navigation

Changeset 269436 in webkit

Legend:

Download in other formats: