Changeset 269560 in webkit


Ignore:
Timestamp:
Nov 6, 2020 10:55:37 PM (3 years ago)
Author:
commit-queue@webkit.org
Message:
REGRESSION (r269435): [iOS Debug] ASSERTION FAILED: !m_impl
Thread::mayBeGCThread() m_impl->wasConstructedOnMainThread() == isMainThread()

​https://bugs.webkit.org/show_bug.cgi?id=218662

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-11-06
Reviewed by Chris Dumez.

We were missing a few WebThreadLock calls, which changes the return value of isMainThread() in UIWebView.

  • TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLNoCrashOnOtherThreadAccess.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm:

(TestWebKitAPI::TEST):

Location:
trunk/Tools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Tools/ChangeLog

    r269555 r269560  
     12020-11-06  Alex Christensen  <achristensen@webkit.org>
     2
     3        REGRESSION (r269435): [iOS Debug] ASSERTION FAILED: !m_impl || Thread::mayBeGCThread() || m_impl->wasConstructedOnMainThread() == isMainThread()
     4        https://bugs.webkit.org/show_bug.cgi?id=218662
     5
     6        Reviewed by Chris Dumez.
     7
     8        We were missing a few WebThreadLock calls, which changes the return value of isMainThread() in UIWebView.
     9
     10        * TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLNoCrashOnOtherThreadAccess.mm:
     11        (TestWebKitAPI::TEST):
     12        * TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm:
     13        (TestWebKitAPI::TEST):
     14
    1152020-11-06  Aakash Jain  <aakash_jain@apple.com>
    216

  • trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLNoCrashOnOtherThreadAccess.mm

    r267869 r269560  
    172172
    173173    Util::run(&didFinishLoad);
     174    WebThreadLock();
    174175
    175176    RetainPtr<JSContext> jsContext = [uiWebView valueForKeyPath:@"documentView.webView.mainFrame.javaScriptContext"];

  • trunk/Tools/TestWebKitAPI/Tests/WebKitLegacy/ios/WebGLPrepareDisplayOnWebThread.mm

    r262643 r269560  
    8787    Util::run(&isReady);
    8888
     89    WebThreadLock();
     90
    8991    RetainPtr<JSContext> jsContext = [uiWebView valueForKeyPath:@"documentView.webView.mainFrame.javaScriptContext"];
    9092
Note: See TracChangeset for help on using the changeset viewer.