Changeset 269569 in webkit

Timestamp:

Nov 8, 2020 11:49:21 AM (3 years ago)

Author:

Fujii Hironori

Message:

[GraphicsLayerTextureMapper] reflection masks aren't applied
​https://bugs.webkit.org/show_bug.cgi?id=218429

Reviewed by Don Olmstead.

The backing store of the mask layer of replica layers aren't
updated at all since r178111.

• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIncludingSubLayers):
Use updateBackingStoreIncludingSubLayers for the replica layer to
update backing stores recursively instead of updating only one
layer by using updateBackingStoreIfNeeded.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/texmap/GraphicsLayerTextureMapper.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-08  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [GraphicsLayerTextureMapper] reflection masks aren't applied
+        https://bugs.webkit.org/show_bug.cgi?id=218429
+
+        Reviewed by Don Olmstead.
+
+        The backing store of the mask layer of replica layers aren't
+        updated at all since r178111.
+
+        * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
+        (WebCore::GraphicsLayerTextureMapper::updateBackingStoreIncludingSubLayers):
+        Use updateBackingStoreIncludingSubLayers for the replica layer to
+        update backing stores recursively instead of updating only one
+        layer by using updateBackingStoreIfNeeded.
+
 2020-11-08  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp

@@ -537 +537 @@
         downcast<GraphicsLayerTextureMapper>(*maskLayer()).updateBackingStoreIfNeeded();
     if (replicaLayer())
-        downcast<GraphicsLayerTextureMapper>(*replicaLayer()).updateBackingStoreIfNeeded();
+        downcast<GraphicsLayerTextureMapper>(*replicaLayer()).updateBackingStoreIncludingSubLayers();
     for (auto& child : children())
         downcast<GraphicsLayerTextureMapper>(child.get()).updateBackingStoreIncludingSubLayers();