Changeset 269597 in webkit

Timestamp:

Nov 9, 2020 1:18:08 PM (3 years ago)

Author:

keith_miller@apple.com

Message:

Add total counts to sampling profiler dump
​https://bugs.webkit.org/show_bug.cgi?id=218666

Reviewed by Yusuke Suzuki.

This is nice for computing the approximate percentage of total time in a function.

• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::reportTopFunctions):
(JSC::SamplingProfiler::reportTopBytecodes):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/SamplingProfiler.cpp (modified) (8 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-11-09  Keith Miller  <keith_miller@apple.com>
+
+        Add total counts to sampling profiler dump
+        https://bugs.webkit.org/show_bug.cgi?id=218666
+
+        Reviewed by Yusuke Suzuki.
+
+        This is nice for computing the approximate percentage of total time in a function.
+
+        * runtime/SamplingProfiler.cpp:
+        (JSC::SamplingProfiler::reportTopFunctions):
+        (JSC::SamplingProfiler::reportTopBytecodes):
+
 2020-11-08  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/runtime/SamplingProfiler.cpp

@@ -1024 +1024 @@
     }
 
-
+    size_t totalSamples = 0;
     HashMap<String, size_t> functionCounts;
     for (StackTrace& stackTrace : m_stackTraces) {
@@ -1040 +1040 @@
         String frameDescription = makeString(frame.displayName(m_vm), '#', hash, ':', frame.sourceID());
         functionCounts.add(frameDescription, 0).iterator->value++;
+        totalSamples++;
     }
 
@@ -1057 +1058 @@
 
     if (Options::samplingProfilerTopFunctionsCount()) {
-        out.print("\n\nSampling rate: ", m_timingInterval.microseconds(), " microseconds\n");
-        out.print("Top functions as <numSamples  'functionName#hash:sourceID'>\n");
+        out.println("\n\nSampling rate: ", m_timingInterval.microseconds(), " microseconds. Total samples: ", totalSamples);
+        out.println("Top functions as <numSamples  'functionName#hash:sourceID'>");
         for (size_t i = 0; i < Options::samplingProfilerTopFunctionsCount(); i++) {
             auto pair = takeMax();
@@ -1064 +1065 @@
                 break;
             out.printf("%6zu ", pair.second);
-            out.print("   '", pair.first, "'\n");
+            out.println("   '", pair.first, "'");
         }
     }
@@ -1084 +1085 @@
     }
 
+    size_t totalSamples = 0;
     HashMap<String, size_t> bytecodeCounts;
     for (StackTrace& stackTrace : m_stackTraces) {
@@ -1120 +1122 @@
         }
         bytecodeCounts.add(frameDescription, 0).iterator->value++;
+        totalSamples++;
     }
 
@@ -1137 +1140 @@
 
     if (Options::samplingProfilerTopBytecodesCount()) {
-        out.print("\n\nSampling rate: ", m_timingInterval.microseconds(), " microseconds\n");
-        out.print("Hottest bytecodes as <numSamples   'functionName#hash:JITType:bytecodeIndex'>\n");
+        out.println("\n\nSampling rate: ", m_timingInterval.microseconds(), " microseconds. Total samples: ", totalSamples);
+        out.println("Hottest bytecodes as <numSamples   'functionName#hash:JITType:bytecodeIndex'>");
         for (size_t i = 0; i < Options::samplingProfilerTopBytecodesCount(); i++) {
             auto pair = takeMax();
@@ -1144 +1147 @@
                 break;
             out.printf("%6zu ", pair.second);
-            out.print("   '", pair.first, "'\n");
+            out.println("   '", pair.first, "'");
         }
     }