Changeset 269599 in webkit

Timestamp:

Nov 9, 2020 1:28:52 PM (3 years ago)

Author:

Fujii Hironori

Message:

[TextureMapper] backdrop-filter should use the identity transform to render the root layer
​https://bugs.webkit.org/show_bug.cgi?id=218699

Reviewed by Don Olmstead.

Source/WebCore:

Even thouth CSS reflections mirror the content, backdrop-filter in
the reflection doesn't. It sees through the background.
css3/filters/backdrop/backdrop-filter-with-reflection.html is the
test case.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::paintIntoSurface):
(WebCore::TextureMapperLayer::paintWithIntermediateSurface):
Removed TextureMapperPaintOptions::isReplica.

LayoutTests:

• platform/glib/TestExpectations: Unmarked

css3/filters/backdrop/{backdrop-filter-with-reflection-add-backdrop.html,
backdrop-filter-with-reflection-value-change.html,backdrop-filter-with-reflection.html}

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/glib/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [TextureMapper] backdrop-filter should use the identity transform to render the root layer
+        https://bugs.webkit.org/show_bug.cgi?id=218699
+
+        Reviewed by Don Olmstead.
+
+        * platform/glib/TestExpectations: Unmarked
+        css3/filters/backdrop/{backdrop-filter-with-reflection-add-backdrop.html,
+        backdrop-filter-with-reflection-value-change.html,backdrop-filter-with-reflection.html}
+
 2020-11-09  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/LayoutTests/platform/glib/TestExpectations

@@ -279 +279 @@
 webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-border-radius-value-change.html [ ImageOnlyFailure ]
 webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-border-radius.html [ ImageOnlyFailure ]
-webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-reflection-add-backdrop.html [ ImageOnlyFailure ]
-webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-reflection-value-change.html [ ImageOnlyFailure ]
-webkit.org/b/169988 css3/filters/backdrop/backdrop-filter-with-reflection.html [ ImageOnlyFailure ]
 webkit.org/b/169988 css3/filters/backdrop/effect-hw.html [ ImageOnlyFailure ]
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-09  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [TextureMapper] backdrop-filter should use the identity transform to render the root layer
+        https://bugs.webkit.org/show_bug.cgi?id=218699
+
+        Reviewed by Don Olmstead.
+
+        Even thouth CSS reflections mirror the content, backdrop-filter in
+        the reflection doesn't. It sees through the background.
+        css3/filters/backdrop/backdrop-filter-with-reflection.html is the
+        test case.
+
+        * platform/graphics/texmap/TextureMapperLayer.cpp:
+        (WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
+        (WebCore::TextureMapperLayer::paintIntoSurface):
+        (WebCore::TextureMapperLayer::paintWithIntermediateSurface):
+        Removed TextureMapperPaintOptions::isReplica.
+
 2020-11-09  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp

@@ -40 +40 @@
     IntSize offset;
     TextureMapperLayer* backdropLayer { nullptr };
-    bool isReplica { false };
 };
 
@@ -300 +299 @@
     if (m_state.replicaLayer) {
         TextureMapperPaintOptions replicaOptions(options);
-        replicaOptions.isReplica = true;
-        replicaOptions.transform
-            .multiply(m_state.replicaLayer->m_layerTransforms.combined)
-            .multiply(m_layerTransforms.combined.inverse().valueOr(TransformationMatrix()));
+        replicaOptions.transform.multiply(replicaTransform());
         paintSelfAndChildren(replicaOptions);
     }
@@ -438 +434 @@
     if (m_isBackdrop) {
         TextureMapperPaintOptions paintOptions(options);
+        paintOptions.transform = TransformationMatrix();
         paintOptions.backdropLayer = this;
         rootLayer().paintSelfAndChildren(paintOptions);
@@ -463 +460 @@
     paintOptions.opacity = 1;
     if (m_state.replicaLayer) {
-        paintOptions.isReplica = true;
         paintOptions.transform.multiply(replicaTransform());
         paintIntoSurface(paintOptions);
-        paintOptions.isReplica = false;
         paintOptions.transform = options.transform;
         if (m_state.replicaLayer->m_state.maskLayer)
             m_state.replicaLayer->m_state.maskLayer->applyMask(paintOptions);
     }
-
-    if (m_isBackdrop && m_effectTarget->m_state.replicaLayer && options.isReplica)
-        paintOptions.transform = m_effectTarget->replicaTransform();
 
     paintIntoSurface(paintOptions);