Changeset 269754 in webkit

Timestamp:

Nov 12, 2020 2:44:45 PM (3 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION(?): Sources: WebSocket status not shown when organized By Path
​https://bugs.webkit.org/show_bug.cgi?id=218679

Reviewed by Brian Burg.

• UserInterface/Views/SourcesNavigationSidebarPanel.js:

(WI.SourcesNavigationSidebarPanel.prototype._addResource):
Make sure to use WI.WebSocketResourceTreeElement for WI.WebSocketResource.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SourcesNavigationSidebarPanel.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-11-12  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(?): Sources: WebSocket status not shown when organized By Path
+        https://bugs.webkit.org/show_bug.cgi?id=218679
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/SourcesNavigationSidebarPanel.js:
+        (WI.SourcesNavigationSidebarPanel.prototype._addResource):
+        Make sure to use `WI.WebSocketResourceTreeElement` for `WI.WebSocketResource`.
+
 2020-11-11  John Wilander  <wilander@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js

@@ -1081 +1081 @@
             if (resource instanceof WI.CSSStyleSheet)
                 resourceTreeElement = new WI.CSSStyleSheetTreeElement(resource);
-            else
-                resourceTreeElement = new WI.ResourceTreeElement(resource, resource, {allowDirectoryAsName: true, hideOrigin: true});
+            else {
+                let constructor = resource.type === WI.Resource.Type.WebSocket ? WI.WebSocketResourceTreeElement : WI.ResourceTreeElement;
+                resourceTreeElement = new constructor(resource, resource, {allowDirectoryAsName: true, hideOrigin: true});
+            }
 
             let index = insertionIndexForObjectInListSortedByFunction(resourceTreeElement, parentTreeElement.children, this._boundCompareTreeElements);