Changeset 269755 in webkit

Timestamp:

Nov 12, 2020 2:49:39 PM (3 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION(?): Graphics: cannot click on recording icon more than once
​https://bugs.webkit.org/show_bug.cgi?id=218834

Reviewed by Brian Burg.

• UserInterface/Views/ContextMenuUtilities.js:

(WI.addMouseDownContextMenuHandlers):
Only ignore future "mousedown" events if the WI.ContextMenu actually has items.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ContextMenuUtilities.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2020-11-12  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION(?): Graphics: cannot click on recording icon more than once
+        https://bugs.webkit.org/show_bug.cgi?id=218834
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/ContextMenuUtilities.js:
+        (WI.addMouseDownContextMenuHandlers):
+        Only ignore future `"mousedown"` events if the `WI.ContextMenu` actually has items.
+
 2020-11-12  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js

@@ -36 +36 @@
             return;
 
-        ignoreMouseDown = true;
-
         let contextMenu = WI.ContextMenu.createFromEvent(event);
         contextMenu.addBeforeShowCallback(() => {
@@ -45 +43 @@
         populateContextMenuCallback(contextMenu, event);
 
+        ignoreMouseDown = !contextMenu.isEmpty();
         contextMenu.show();
     });