Changeset 269776 in webkit


Ignore:
Timestamp:
Nov 13, 2020 8:00:41 AM (3 years ago)
Author:
commit-queue@webkit.org
Message:

Null check anchorNode of endingSelection start
​https://bugs.webkit.org/show_bug.cgi?id=218492

Patch by Rob Buis <​rbuis@igalia.com> on 2020-11-13
Reviewed by Alex Christensen.

Source/WebCore:

Null check anchorNode of endingSelection start.

Test: editing/deleting/delete-contenteditable-crash.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs):

LayoutTests:

Add testcase.

  • editing/deleting/delete-contenteditable-crash-expected.txt: Added.
  • editing/deleting/delete-contenteditable-crash.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r269772 r269776  
     12020-11-13  Rob Buis  <rbuis@igalia.com>
     2
     3        Null check anchorNode of endingSelection start
     4        https://bugs.webkit.org/show_bug.cgi?id=218492
     5
     6        Reviewed by Alex Christensen.
     7
     8        Add testcase.
     9
     10        * editing/deleting/delete-contenteditable-crash-expected.txt: Added.
     11        * editing/deleting/delete-contenteditable-crash.html: Added.
     12
    1132020-11-13  Miguel Gomez  <magomez@igalia.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r269775 r269776  
     12020-11-13  Rob Buis  <rbuis@igalia.com>
     2
     3        Null check anchorNode of endingSelection start
     4        https://bugs.webkit.org/show_bug.cgi?id=218492
     5
     6        Reviewed by Alex Christensen.
     7
     8        Null check anchorNode of endingSelection start.
     9
     10        Test: editing/deleting/delete-contenteditable-crash.html
     11
     12        * editing/DeleteSelectionCommand.cpp:
     13        (WebCore::DeleteSelectionCommand::mergeParagraphs):
     14
    1152020-11-13  Aditya Keerthi  <akeerthi@apple.com>
    216

  • trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp

    r267363 r269776  
    762762
    763763    // FIXME (Bug 211793): endingSelection() becomes disconnected in moveParagraph
    764     if (endingSelection().start().anchorNode()->isConnected())
     764    if (auto* anchorNode = endingSelection().start().anchorNode(); anchorNode && anchorNode->isConnected())
    765765        m_endingPosition = endingSelection().start();
    766766}
Note: See TracChangeset for help on using the changeset viewer.