Changeset 269787 in webkit


Ignore:
Timestamp:
Nov 13, 2020 1:09:06 PM (3 years ago)
Author:
Jonathan Bedard
Message:

REGRESSION: r269514 Reset server port before restarting webserver
https://bugs.webkit.org/show_bug.cgi?id=218918
<rdar://problem/71380345>

Reviewed by Stephanie Lewis.

  • Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:

(SimpleHTTPServerDriver.serve): Reset server port.
(SimpleHTTPServerDriver.kill_server): Ditto.

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r269786 r269787  
     12020-11-13  Jonathan Bedard  <jbedard@apple.com>
     2
     3        REGRESSION: r269514 Reset server port before restarting webserver
     4        https://bugs.webkit.org/show_bug.cgi?id=218918
     5        <rdar://problem/71380345>
     6
     7        Reviewed by Stephanie Lewis.
     8
     9        * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
     10        (SimpleHTTPServerDriver.serve): Reset server port.
     11        (SimpleHTTPServerDriver.kill_server): Ditto.
     12
    1132020-11-13  Aakash Jain  <aakash_jain@apple.com>
    214
  • trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py

    r269514 r269787  
    3333        if self._ip:
    3434            interface_args.extend(['--interface', self._ip])
     35        self._server_port = 0
    3536        self._server_process = subprocess.Popen(["python", http_server_path, web_root] + interface_args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
    3637        max_attempt = 5
     
    8788    def kill_server(self):
    8889        try:
     90            self._server_port = 0
    8991            if not self._server_process:
    9092                return
Note: See TracChangeset for help on using the changeset viewer.