Changeset 269803 in webkit

Timestamp:

Nov 13, 2020 2:56:53 PM (3 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, reverting r269776.

The test added with this change is asserting

Reverted changeset:

"Null check anchorNode of endingSelection start"
​https://bugs.webkit.org/show_bug.cgi?id=218492
​https://trac.webkit.org/changeset/269776

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/deleting/delete-contenteditable-crash-expected.txt (deleted)
• LayoutTests/editing/deleting/delete-contenteditable-crash.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/editing/DeleteSelectionCommand.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-11-13  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, reverting r269776.
+
+        The test added with this change is asserting
+
+        Reverted changeset:
+
+        "Null check anchorNode of endingSelection start"
+        https://bugs.webkit.org/show_bug.cgi?id=218492
+        https://trac.webkit.org/changeset/269776
+
 2020-11-13  Sergey Rubanov  <chi187@gmail.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-13  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, reverting r269776.
+
+        The test added with this change is asserting
+
+        Reverted changeset:
+
+        "Null check anchorNode of endingSelection start"
+        https://bugs.webkit.org/show_bug.cgi?id=218492
+        https://trac.webkit.org/changeset/269776
+
 2020-11-13  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/WebCore/editing/DeleteSelectionCommand.cpp

@@ -762 +762 @@
 
     // FIXME (Bug 211793): endingSelection() becomes disconnected in moveParagraph
-    if (auto* anchorNode = endingSelection().start().anchorNode(); anchorNode && anchorNode->isConnected())
+    if (endingSelection().start().anchorNode()->isConnected())
         m_endingPosition = endingSelection().start();
 }