Changeset 269814 in webkit


Ignore:
Timestamp:
Nov 14, 2020 2:28:55 AM (3 years ago)
Author:
don.olmstead@sony.com
Message:

[clang-tidy] Run modernize-use-override through JSC
​https://bugs.webkit.org/show_bug.cgi?id=218916

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

  • inspector/agents/InspectorAgent.h:
  • inspector/agents/InspectorScriptProfilerAgent.h:
  • inspector/agents/InspectorTargetAgent.h:
  • inspector/agents/JSGlobalObjectAuditAgent.h:
  • inspector/agents/JSGlobalObjectDebuggerAgent.h:
  • inspector/agents/JSGlobalObjectRuntimeAgent.h:
  • inspector/remote/socket/RemoteInspectorConnectionClient.h:
  • inspector/remote/socket/RemoteInspectorServer.h:
  • runtime/JSGlobalObjectDebuggable.h:

Source/WTF:

  • wtf/RunLoop.h:
Location:
trunk/Source
Files:
12 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r269801 r269814  
     12020-11-14  Don Olmstead  <don.olmstead@sony.com>
     2
     3        [clang-tidy] Run modernize-use-override through JSC
     4        https://bugs.webkit.org/show_bug.cgi?id=218916
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        * inspector/agents/InspectorAgent.h:
     9        * inspector/agents/InspectorScriptProfilerAgent.h:
     10        * inspector/agents/InspectorTargetAgent.h:
     11        * inspector/agents/JSGlobalObjectAuditAgent.h:
     12        * inspector/agents/JSGlobalObjectDebuggerAgent.h:
     13        * inspector/agents/JSGlobalObjectRuntimeAgent.h:
     14        * inspector/remote/socket/RemoteInspectorConnectionClient.h:
     15        * inspector/remote/socket/RemoteInspectorServer.h:
     16        * runtime/JSGlobalObjectDebuggable.h:
     17
    1182020-11-13  Xan López  <xan@igalia.com>
    219

  • trunk/Source/JavaScriptCore/inspector/agents/InspectorAgent.h

    r266885 r269814  
    4646public:
    4747    InspectorAgent(AgentContext&);
    48     ~InspectorAgent();
     48    ~InspectorAgent() final;
    4949
    5050    // InspectorAgentBase
    51     void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*);
    52     void willDestroyFrontendAndBackend(DisconnectReason);
     51    void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*) final;
     52    void willDestroyFrontendAndBackend(DisconnectReason) final;
    5353
    5454    // InspectorBackendDispatcherHandler
    55     Protocol::ErrorStringOr<void> enable();
    56     Protocol::ErrorStringOr<void> disable();
    57     Protocol::ErrorStringOr<void> initialized();
     55    Protocol::ErrorStringOr<void> enable() final;
     56    Protocol::ErrorStringOr<void> disable() final;
     57    Protocol::ErrorStringOr<void> initialized() final;
    5858
    5959    // CommandLineAPI

  • trunk/Source/JavaScriptCore/inspector/agents/InspectorScriptProfilerAgent.h

    r266885 r269814  
    4343public:
    4444    InspectorScriptProfilerAgent(AgentContext&);
    45     ~InspectorScriptProfilerAgent();
     45    ~InspectorScriptProfilerAgent() final;
    4646
    4747    // InspectorAgentBase
    48     void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*);
    49     void willDestroyFrontendAndBackend(DisconnectReason);
     48    void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*) final;
     49    void willDestroyFrontendAndBackend(DisconnectReason) final;
    5050
    5151    // ScriptProfilerBackendDispatcherHandler
    52     Protocol::ErrorStringOr<void> startTracking(Optional<bool>&& includeSamples);
    53     Protocol::ErrorStringOr<void> stopTracking();
     52    Protocol::ErrorStringOr<void> startTracking(Optional<bool>&& includeSamples) final;
     53    Protocol::ErrorStringOr<void> stopTracking() final;
    5454
    5555    // JSC::Debugger::ProfilingClient
    56     bool isAlreadyProfiling() const;
    57     Seconds willEvaluateScript();
    58     void didEvaluateScript(Seconds, JSC::ProfilingReason);
     56    bool isAlreadyProfiling() const final;
     57    Seconds willEvaluateScript() final;
     58    void didEvaluateScript(Seconds, JSC::ProfilingReason) final;
    5959
    6060private:

  • trunk/Source/JavaScriptCore/inspector/agents/InspectorTargetAgent.h

    r266885 r269814  
    4141public:
    4242    InspectorTargetAgent(FrontendRouter&, BackendDispatcher&);
    43     ~InspectorTargetAgent();
     43    ~InspectorTargetAgent() final;
    4444
    4545    // InspectorAgentBase
    46     void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*);
    47     void willDestroyFrontendAndBackend(DisconnectReason);
     46    void didCreateFrontendAndBackend(FrontendRouter*, BackendDispatcher*) final;
     47    void willDestroyFrontendAndBackend(DisconnectReason) final;
    4848
    4949    // TargetBackendDispatcherHandler
    50     Protocol::ErrorStringOr<void> setPauseOnStart(bool);
    51     Protocol::ErrorStringOr<void> resume(const String& targetId);
    52     Protocol::ErrorStringOr<void> sendMessageToTarget(const String& targetId, const String& message);
     50    Protocol::ErrorStringOr<void> setPauseOnStart(bool) final;
     51    Protocol::ErrorStringOr<void> resume(const String& targetId) final;
     52    Protocol::ErrorStringOr<void> sendMessageToTarget(const String& targetId, const String& message) final;
    5353
    5454    // Target lifecycle.

  • trunk/Source/JavaScriptCore/inspector/agents/JSGlobalObjectAuditAgent.h

    r266885 r269814  
    3939public:
    4040    JSGlobalObjectAuditAgent(JSAgentContext&);
    41     ~JSGlobalObjectAuditAgent();
     41    ~JSGlobalObjectAuditAgent() final;
    4242
    4343private:
    44     InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&);
     44    InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&) final;
    4545
    4646    JSC::JSGlobalObject& m_globalObject;

  • trunk/Source/JavaScriptCore/inspector/agents/JSGlobalObjectDebuggerAgent.h

    r266885 r269814  
    3737public:
    3838    JSGlobalObjectDebuggerAgent(JSAgentContext&, InspectorConsoleAgent*);
    39     ~JSGlobalObjectDebuggerAgent();
     39    ~JSGlobalObjectDebuggerAgent() final;
    4040
    4141    // JSC::Debugger::Observer
    42     void breakpointActionLog(JSC::JSGlobalObject*, const String& data);
     42    void breakpointActionLog(JSC::JSGlobalObject*, const String& data) final;
    4343
    4444private:
    45     InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&);
     45    InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&) final;
    4646
    4747    // NOTE: JavaScript inspector does not yet need to mute a console because no messages
    4848    // are sent to the console outside of the API boundary or console object.
    49     void muteConsole() { }
    50     void unmuteConsole() { }
     49    void muteConsole() final { }
     50    void unmuteConsole() final { }
    5151
    5252    InspectorConsoleAgent* m_consoleAgent { nullptr };

  • trunk/Source/JavaScriptCore/inspector/agents/JSGlobalObjectRuntimeAgent.h

    r266885 r269814  
    4040public:
    4141    JSGlobalObjectRuntimeAgent(JSAgentContext&);
    42     ~JSGlobalObjectRuntimeAgent();
     42    ~JSGlobalObjectRuntimeAgent() final;
    4343
    4444private:
    45     InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&);
     45    InjectedScript injectedScriptForEval(Protocol::ErrorString&, Optional<Protocol::Runtime::ExecutionContextId>&&) final;
    4646
    4747    // NOTE: JavaScript inspector does not yet need to mute a console because no messages
    4848    // are sent to the console outside of the API boundary or console object.
    49     void muteConsole() { }
    50     void unmuteConsole() { }
     49    void muteConsole() final { }
     50    void unmuteConsole() final { }
    5151
    5252    std::unique_ptr<RuntimeFrontendDispatcher> m_frontendDispatcher;

  • trunk/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.h

    r267807 r269814  
    4242class JS_EXPORT_PRIVATE RemoteInspectorConnectionClient : public RemoteInspectorSocketEndpoint::Client {
    4343public:
    44     virtual ~RemoteInspectorConnectionClient();
     44    ~RemoteInspectorConnectionClient() override;
    4545
    4646    Optional<ConnectionID> connectInet(const char* serverAddr, uint16_t serverPort);

  • trunk/Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorServer.h

    r269128 r269814  
    3535class RemoteInspectorServer final : public RemoteInspectorSocketEndpoint::Listener {
    3636public:
    37     ~RemoteInspectorServer();
     37    ~RemoteInspectorServer() final;
    3838
    3939    JS_EXPORT_PRIVATE static RemoteInspectorServer& singleton();

  • trunk/Source/JavaScriptCore/runtime/JSGlobalObjectDebuggable.h

    r262302 r269814  
    4545public:
    4646    JSGlobalObjectDebuggable(JSGlobalObject&);
    47     ~JSGlobalObjectDebuggable() { }
     47    ~JSGlobalObjectDebuggable() final { }
    4848
    4949    Inspector::RemoteControllableTarget::Type type() const final { return m_type; }

  • trunk/Source/WTF/ChangeLog

    r269810 r269814  
     12020-11-14  Don Olmstead  <don.olmstead@sony.com>
     2
     3        [clang-tidy] Run modernize-use-override through JSC
     4        https://bugs.webkit.org/show_bug.cgi?id=218916
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        * wtf/RunLoop.h:
     9
    1102020-11-13  Sihui Liu  <sihui_liu@apple.com>
    211

  • trunk/Source/WTF/wtf/RunLoop.h

    r269714 r269814  
    8383    ~RunLoop() final;
    8484
    85     WTF_EXPORT_PRIVATE void dispatch(Function<void()>&&);
     85    WTF_EXPORT_PRIVATE void dispatch(Function<void()>&&) final;
    8686    WTF_EXPORT_PRIVATE void dispatchAfter(Seconds, Function<void()>&&);
    8787#if USE(COCOA_EVENT_LOOP)
Note: See TracChangeset for help on using the changeset viewer.