Changeset 269821 in webkit

Timestamp:

Nov 14, 2020 1:43:44 PM (3 years ago)

Author:

Alan Bujtas

Message:

[LFC][IFC] Negative margin before (>border box height value) completely pulls the inline level box out of the line box
​https://bugs.webkit.org/show_bug.cgi?id=218945

Reviewed by Antti Koivisto.

maximumTopOffsetFromRootInlineBoxBaseline could very well be negative e.g
<div><div style="display: inline-block; height: 10px; margin-top: -20px"></div></div>.

• layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/inlineformatting/InlineFormattingContextGeometry.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-14  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][IFC] Negative margin before (>border box height value) completely pulls the inline level box out of the line box
+        https://bugs.webkit.org/show_bug.cgi?id=218945
+
+        Reviewed by Antti Koivisto.
+
+        maximumTopOffsetFromRootInlineBoxBaseline could very well be negative e.g
+        <div><div style="display: inline-block; height: 10px; margin-top: -20px"></div></div>.
+
+        * layout/inlineformatting/InlineFormattingContextGeometry.cpp:
+        (WebCore::Layout::LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically):
+
 2020-11-14  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp

@@ -405 +405 @@
         inlineLevelBoxAbsoluteBaselineOffsetMap.add(&rootInlineBox, InlineLayoutUnit { });
 
-        auto maximumTopOffsetFromRootInlineBoxBaseline = rootInlineBox.isEmpty() ? InlineLayoutUnit() : rootInlineBox.layoutBounds().ascent;
+        auto maximumTopOffsetFromRootInlineBoxBaseline = rootInlineBox.isEmpty() ? std::numeric_limits<InlineLayoutUnit>::min() : rootInlineBox.layoutBounds().ascent;
 
         for (auto& inlineLevelBox : lineBox.nonRootInlineLevelBoxes()) {