Changeset 269836 in webkit

Timestamp:

Nov 15, 2020 8:53:16 PM (3 years ago)

Author:

Alan Bujtas

Message:

[LFC][Integration] Disable modern line layout for fieldset children.
​https://bugs.webkit.org/show_bug.cgi?id=218963

Reviewed by Sam Weinig.

Fieldsets don't follow the standard CSS box model. They require special handling.

• layout/integration/LayoutIntegrationCoverage.cpp:

(WebCore::LayoutIntegration::canUseForChild):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• layout/integration/LayoutIntegrationCoverage.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-15  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC][Integration] Disable modern line layout for fieldset children.
+        https://bugs.webkit.org/show_bug.cgi?id=218963
+
+        Reviewed by Sam Weinig.
+
+        Fieldsets don't follow the standard CSS box model. They require special handling.
+
+        * layout/integration/LayoutIntegrationCoverage.cpp:
+        (WebCore::LayoutIntegration::canUseForChild):
+
 2020-11-15  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

@@ -575 +575 @@
         return reasons;
 
+    if (child.isFieldset()) {
+        // Fieldsets don't follow the standard CSS box model. They require special handling.
+        SET_REASON_AND_RETURN_IF_NEEDED(FlowHasNonSupportedChild, reasons, includeReasons)
+    }
+
 #if ALLOW_IMAGES || ALLOW_ALL_REPLACED
     if (is<RenderReplaced>(child)) {