Changeset 269846 in webkit

Timestamp:

Nov 16, 2020 3:28:40 AM (3 years ago)

Author:

Devin Rousso

Message:

[iPad] nhl.com cannot select new video to play while video is playing with desktop UA
​https://bugs.webkit.org/show_bug.cgi?id=218868
<rdar://problem/67823088>

Reviewed by Antoine Quint.

The desktop "version" of this site uses custom media controls that don't work well on iOS
because they rely on mouse events (which is why it was quirked in r255592). The mobile
"version" uses the default/native media controls, so there is no issue.

Currently, when tapping on another video with a desktop UA, the site uses its touch event
handlers for mouse events. These handlers call Event.prototype.preventDefault if the event
is not a touch event, meaning that "click" is not fired. This prevents new videos from
being played.

Rather than limit the quirk based on some DOM state (which is fragile if the site changes),
just have the entire site default to a mobile UA.

Source/WebCore:

• page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

Source/WebKit:

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::desktopClassBrowsingRecommendedForRequest):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/Quirks.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/ios/WebPageProxyIOS.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-11-16  Devin Rousso  <drousso@apple.com>
+
+        [iPad] nhl.com cannot select new video to play while video is playing with desktop UA
+        https://bugs.webkit.org/show_bug.cgi?id=218868
+        <rdar://problem/67823088>
+
+        Reviewed by Antoine Quint.
+
+        The desktop "version" of this site uses custom media controls that don't work well on iOS
+        because they rely on mouse events (which is why it was quirked in r255592). The mobile
+        "version" uses the default/native media controls, so there is no issue.
+
+        Currently, when tapping on another video with a desktop UA, the site uses its touch event
+        handlers for mouse events. These handlers call `Event.prototype.preventDefault` if the event
+        is not a touch event, meaning that `"click"` is not fired. This prevents new videos from
+        being played.
+
+        Rather than limit the quirk based on some DOM state (which is fragile if the site changes),
+        just have the entire site default to a mobile UA.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+
 2020-11-16  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -377 +377 @@
         if (host == "naver.com")
             return true;
-        if (host == "nhl.com" || (host.endsWith(".nhl.com") && !host.startsWith("account.")))
-            return true;
         if (host == "nba.com" || host.endsWith(".nba.com"))
             return true;

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-11-16  Devin Rousso  <drousso@apple.com>
+
+        [iPad] nhl.com cannot select new video to play while video is playing with desktop UA
+        https://bugs.webkit.org/show_bug.cgi?id=218868
+        <rdar://problem/67823088>
+
+        Reviewed by Antoine Quint.
+
+        The desktop "version" of this site uses custom media controls that don't work well on iOS
+        because they rely on mouse events (which is why it was quirked in r255592). The mobile
+        "version" uses the default/native media controls, so there is no issue.
+
+        Currently, when tapping on another video with a desktop UA, the site uses its touch event
+        handlers for mouse events. These handlers call `Event.prototype.preventDefault` if the event
+        is not a touch event, meaning that `"click"` is not fired. This prevents new videos from
+        being played.
+
+        Rather than limit the quirk based on some DOM state (which is fragile if the site changes),
+        just have the entire site default to a mobile UA.
+
+        * UIProcess/ios/WebPageProxyIOS.mm:
+        (WebKit::desktopClassBrowsingRecommendedForRequest):
+
 2020-11-16  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm

@@ -1419 +1419 @@
     }
 
+    if (equalLettersIgnoringASCIICase(host, "nhl.com") || host.endsWithIgnoringASCIICase(".nhl.com"))
+        return RecommendDesktopClassBrowsingForRequest::No;
+
     // FIXME: Remove this quirk when <rdar://problem/59480381> is complete.
     if (equalLettersIgnoringASCIICase(host, "fidelity.com") || host.endsWithIgnoringASCIICase(".fidelity.com"))