Changeset 269885 in webkit


Ignore:
Timestamp:
Nov 16, 2020 3:51:48 PM (3 years ago)
Author:
wilander@apple.com
Message:

NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds
https://bugs.webkit.org/show_bug.cgi?id=218997
<rdar://problem/71460604>

Unreviewed minor change to logging.

NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the
cookie name in log output on customer builds. This patch changes the format
specifier from %s to %{public}s.

Note that this logging is just for ITP Debug Mode which is off by default, logs
in-memory only, and is disabled again on browser quit.

No new tests. This just changes log output on customer builds.

  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking):

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r269879 r269885  
     12020-11-16  John Wilander  <wilander@apple.com>
     2
     3        NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the cookie name in log output on customer builds
     4        https://bugs.webkit.org/show_bug.cgi?id=218997
     5        <rdar://problem/71460604>
     6
     7        Unreviewed minor change to logging.
     8
     9        NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking() redacts the
     10        cookie name in log output on customer builds. This patch changes the format
     11        specifier from %s to %{public}s.
     12
     13        Note that this logging is just for ITP Debug Mode which is off by default, logs
     14        in-memory only, and is disabled again on browser quit.
     15
     16        No new tests. This just changes log output on customer builds.
     17
     18        * NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
     19        (WebKit::NetworkDataTaskCocoa::applyCookiePolicyForThirdPartyCNAMECloaking):
     20
    1212020-11-16  Chris Dumez  <cdumez@apple.com>
    222
  • trunk/Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm

    r268030 r269885  
    206206                [cappedCookies addObject:cookie];
    207207                if (debugLoggingEnabled)
    208                     RELEASE_LOG_INFO(ITPDebug, "Capped the expiry of third-party CNAME cloaked cookie named %s.", [[cookie name] UTF8String]);
     208                    RELEASE_LOG_INFO(ITPDebug, "Capped the expiry of third-party CNAME cloaked cookie named %{public}s.", [[cookie name] UTF8String]);
    209209            }
    210210            return cappedCookies;
Note: See TracChangeset for help on using the changeset viewer.